Closed
Bug 235139
Opened 20 years ago
Closed 20 years ago
Error dialog should block continued execution of installer
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
References
Details
Attachments
(1 file)
|
1013 bytes,
patch
|
dveditz
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
Most of the time when the installer puts up an error dialog, it's already waiting for input and does not continue until the user closes the error dialog. But this is not always true. Specifically, once installation has actually started, the installer no longer pays attention to input, so any error dialogs get torn down at installer exit even if the user hasn't read the error message yet. ErrorHandler should block the installer from continuing.
|
Assignee | |
Comment 1•20 years ago
|
||
this calls gtk_main/gtk_main_quit, which is what the now-ripped-out completion dialog did for the same effect.
|
|
Assignee | |
Updated•20 years ago
|
Attachment #141896 -
Flags: review?(dveditz+bmo)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 141896 [details] [diff] [review] patch r=dveditz
Attachment #141896 -
Flags: review?(dveditz+bmo) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #141896 -
Flags: superreview?(bryner)
|
||
Updated•20 years ago
|
Attachment #141896 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Comment 3•20 years ago
|
||
fix checked in by bz
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•