235171 - [FIX]TEXTAREA narrow than set by COLS= (newlines don't end unquoted attributes)

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[noririty]

- Occurs On 20040219
- Doesn't Occur On 20040221

Comment 1

[noririty]

oops, it was opposite.
- Doesn't Occur On 20040219
- Occurs On 20040221

Comment 2

[Boris Zbarsky [:bzbarsky]]

What are the times to go with those dates?  What about 2004-02-20-XX?

Comment 3

[Boris Zbarsky [:bzbarsky]]

This is a parser issue (look in DOM inspector and notice that the cols attr
isn't even set).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

The idea here is to only allow newlines inside quoted attrs.  Other attrs
should be terminated by newlines.

Comment 5

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 137315 

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 141974 [details] [diff] [review]
Fix

+      else if(aAllowNewlines && ch == kCR) {
...
>+      else if(aAllowNewlines && ch == kNewLine) {

Would it not generally be faster to check ch == k... before checking
aAllowNewlines?

sr=jst

Comment 7

[Boris Zbarsky [:bzbarsky]]

Hmm.. probably.  I will change that before checking in.

Comment 8

[Boris Zbarsky [:bzbarsky]]

*** Bug 235340 has been marked as a duplicate of this bug. ***

Comment 9

[Boris Zbarsky [:bzbarsky]]

Checked in, with that change.

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 235497 has been marked as a duplicate of this bug. ***