235298 - background image renders page unreadable: shows colored hash on black

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Roy Zimmer]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

the background gif by itself looks ok; combined with the page it results in
horizontal black bands with some colored hash in them: one stripe of visible
page, one black band, etc.
page displays fine in Opera 7.21, IE 6.n

Reproducible: Always
Steps to Reproduce:
1.viewing the page results in the problem situation
2.
3.

Actual Results:  
see Details box

Expected Results:  
rendered the page correctly

I am not associated with the page referenced in this report.

Comment 1

[tor]

Attachment: identify gif with invalid end-of-stream marker as corrupt

Comment 2

[Stuart Parmenter]

Comment on attachment 142061 [details] [diff] [review]
identify gif with invalid end-of-stream marker as corrupt

maybe add a comment in the code that points to this bug or explains why we need
to error our there.  other than that looks ok to me

Comment 3

[tor]

Attachment: more comments

Comment 4

[Darin Fisher]

Comment on attachment 142144 [details] [diff] [review]
more comments

>Index: GIF2.cpp

>+      if (code == (clear_code + 1)) {
>+        /* end-of-stream should only appear after all image data */
>+        if (rows_remaining != 0)
>+          return -1;
>+        else
>+          return 0;
>+      }

nit: you don't need an else after a return.


>Index: nsGIFDecoder2.cpp

>+  // if the gif is corrupt don't mark the frame as complete, as nsCSSRendering
>+  // will happily try using it try drawing backgrounds

nit: this comment doesn't read right... some missing words between "it" and
"try"?

Comment 5

[tor]

Checked in.

Comment 6

[tor]

(with nits fixed)