235394 - Standalone Composer/Nvu build fails after checkin for bug 224829

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect, P1)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

The fix for bug 224829 broke the build of Standalone Composer.

Comment 1

[Bill Mason]

A proposed patch to resolve this is already in bug 235318.

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: simple fix

The fixes the problem, and makes Standalone Composer use the old autocomplete
textbox (the new one horks the Link Insertion dialog).

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 142114 [details] [diff] [review]
simple fix

mscott/dbaron, can you r/sr please ?

Comment 4

[Bill Mason]

*** Bug 235318 has been marked as a duplicate of this bug. ***

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: simple fix take 2

thanks basic for comment/test on #mozilla

Comment 6

[Benjamin Smedberg]

Comment on attachment 142125 [details] [diff] [review]
simple fix take 2

>-ifndef MOZ_THUNDERBIRD
>+ifdef MOZ_THUNDERBIRD
>+define MOZ_STANDALONE_NONBROWSER_XULAPP
>+1
>+endef
>+endif

replace the define/endef with a simple
MOZ_STANDALONE_NONBROWSER_XULAPP = 1

and r=me

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

checked in

Comment 8

[Pierre Chanial]

common guys...
I have no pb with ifdef'ing toolkit/components/Makefile.in or files in
toolkit/mozapps. However xul.css and "core" widgets (content/widgets) are not
supposed to be forked across xul applications. That would hamper integrating the
"core" toolkit into the GRE and even without considering this option, firefox,
thunderbird and the standalone composer are toolkit clients. As such they should
not fragment it to fit their particular needs.
I fully understand that converting your code to use the new autocomplete is not
your priority, but very little effort would be required to move those bindings
into app specific css files and override the defaults. 
Also, if this patch has been approved by a mozilla/toolkit peer, please write
the name down.