235397 - Esc key closes view-source window

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Christian Schmidt]

Steps to reproduce:
1. Open view-source window
2. Hit the Esc key

Actual results:
View-source window closed

Expected results:
Nothing should happen, because view-source is a window, not a dialog. Closing
windows with Esc is non-standard on Windows.

This is particularly annoying when using find-as-you-type, because Esc is used
to cancel a search:
1. Open view-source window
2. Search for the text "foo" by typing "/foo"
3. Now you change your mind, you want to search for bar instead, so you hit Esc.

Expected result:
Your search should be cancelled and nothing else.

Expected result:
The view-source window is closed.

I am using Firefox 0.8 for Windows.

Comment 1

[Christian Schmidt]

Attachment: Trivial patch to Firefox

I don't think this bug applies to the Suite.

Comment 2

[José Jeria]

Shouldnt the product be set to Firefox?

Comment 3

[Adam Hauner]

WFM 2004021900/trunk SeaMonkey/W2K
-> Firefox

Comment 4

[Doron Rosenberg (IBM)]

Comment on attachment 142118 [details] [diff] [review]
Trivial patch to Firefox

IE doesn't behave this way, so I assume this should get fixed in firewhatever.

r=doron

Comment 5

[Jesse Ruderman]

I like being able to close View Source with Esc.  The real problem is bug
233155, FAYT not eating the Esc.

Comment 6

[Christian Schmidt]

When Firefox supports reloading of the page in View Source as Mozilla 1.7a does
(Firefox doesn't yet support this, right?), I think Esc should be used to stop
the load like it does in a regular browser window.

Comment 7

[Jesse Ruderman]

Ben fixed this today.

Comment 8

[Hiro]

It checked that bug had fixed.

Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.7b) Gecko/20040304
Firefox/0.8.0+

Comment 9

[Fahmida Noor]

I have reproduced this bug with Firefox Nightly 0.8.0+ on Windows 7(64-bit).

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.7b) Gecko/20040224 Firefox/0.8.0+

Verified as fixed with Latest Firefox Nightly 46.0a1 (Build ID : 20160114030246)

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0

[bugday-20160113]