Closed
Bug 235461
Opened 21 years ago
Closed 21 years ago
address book leak in [nsAbDirectoryDataSource::createDirectoryChildNode]
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.7beta
People
(Reporter: mscott, Assigned: mscott)
References
Details
Attachments
(1 file)
|
2.57 KB,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
There's some nasty code that also leaks all but the last mailing list RDF node.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 142157 [details] [diff] [review]
the fix
1) Rewrite createDirectoryChildNode to just return the last element in the
directory array instead of looping to the last one. Remove all of the early
returns.
2) add else clauses to createDirectoryNode to speed up execution time instead
of doing every if test for every call.
Attachment #142157 -
Flags: superreview?(bienvenu)
|
||
Updated•21 years ago
|
Attachment #142157 -
Flags: superreview?(bienvenu) → superreview+
|
|
Assignee | |
Comment 3•21 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7beta
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
|
||
Comment 4•20 years ago
|
||
*** Bug 181212 has been marked as a duplicate of this bug. ***
|
||
Comment 5•19 years ago
|
||
*** Bug 175180 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•