Closed Bug 235461 Opened 21 years ago Closed 20 years ago

address book leak in [nsAbDirectoryDataSource::createDirectoryChildNode]

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7beta

People

(Reporter: mscott, Assigned: mscott)

References

Details

Attachments

(1 file)

There's some nasty code that also leaks all but the last mailing list RDF node.
Attached patch the fixSplinter Review
Comment on attachment 142157 [details] [diff] [review]
the fix

1) Rewrite createDirectoryChildNode to just return the last element in the
directory array instead of looping to the last one. Remove all of the early
returns.

2) add else clauses to createDirectoryNode to speed up execution time instead
of doing every if test for every call.
Attachment #142157 - Flags: superreview?(bienvenu)
Attachment #142157 - Flags: superreview?(bienvenu) → superreview+
checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7beta
Product: Browser → Seamonkey
*** Bug 181212 has been marked as a duplicate of this bug. ***
*** Bug 175180 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: