235504 - Remove nsCString::EqualsWithConversion(const char*)

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

There's no need for this function. Comparing a CString with a char* string does
not do any conversion.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Darin Fisher]

Comment on attachment 145208 [details] [diff] [review]
patch

>Index: xpcom/string/public/nsTString.h

>+#ifdef CharT_is_char
>+      PRBool EqualsIgnoreCase( const char* aString, PRInt32 aCount=-1 ) const {
>+        return Compare(aString, PR_TRUE, aCount) == 0;
>+      }
>+#endif
>+
>+#ifdef CharT_is_PRUnichar
>         /**
>          * Equality check between given string and this string.
>          *
>          * @param   aString is the string to check
>          * @param   aIgnoreCase tells us how to treat case
>          * @param   aCount tells us how many chars to compare
>          * @return  boolean
>          */
> 
>       NS_COM PRBool EqualsWithConversion( const char* aString, PRBool aIgnoreCase=PR_FALSE, PRInt32 aCount=-1 ) const;
>       PRBool EqualsIgnoreCase( const char* aString, PRInt32 aCount=-1 ) const
>         {
>           return EqualsWithConversion(aString, PR_TRUE, aCount);
>         }

I think it would be better to declare the CharT_is_char version of
EqualsIgnoreCase underneath the comment that formerly documented
its behavior.  That's where the other one lives.

Maybe you could use #else also?

r=darin

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: with darin's comments

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

I backed out the string api changes for the moment because they caused bustage
and I don't currently have time for dealing with it...

I'll reland sometime soon

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, checked in again