235537 - Crash while opening the Downloadmanager

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P1)

Description

[Matthias Versen [:Matti]]

win2k build 20040224

I got this a few time during the last weeks and I always fixed it by deleting the 
downloads.rdf in the profile...

Steps to reproduce:
1) download http://matti.no-ip.org/downloads.zip
2) put the "downlods.rdf" in your profile and replace the exiting one
3) start Mozilla and open the Downloadmanager -> crash

Top 2 lines from teh stack :
nsInputStreamPump::AsyncRead(nsInputStreamPump * const 0x02d9f890,
nsIStreamListener * 0x02d9f85c, nsISupports * 0x00000000) line 247 + 8 bytes
nsIconChannel::AsyncOpen(nsIconChannel * const 0x00000000, nsIStreamListener *
0x029009f0, nsISupports * 0x00000000) line 210

Trying Networking first :-)

Comment 1

[Matthias Versen [:Matti]]

Attachment: Full Stack trace

Comment 2

[Tobias Fischer]

I have had a lookalike crash in January, posted it in d.c.s.m.nb
<btj4d5$ifk$06$[e-mail]> with a small non-debugger stack.

In Matti's downloads.rdf I have deleted (o.k., little dirty) omly the line:

<RDF:li
RDF:resource="file:///C:/Dokumente%20und%20Einstellungen/matti/Anwendungsdaten/Mozilla/Profiles/Matti2/gnj7ycwv.slt/\\SERVER600\c\Programme\xitami\webpages\schugga.html"/>

and mozilla is not crashing again while opening the downloadmanager. 

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

so the problem was: MakeInputStream failed to create a stream, but returned
success. but the stream was null. that was bad :)
fix: return an error.

Comment 4

[[e-mail]]

Comment on attachment 142360 [details] [diff] [review]
patch

Bonus points if you can make the channel handle bogus files more usefully ;-)

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in win/nsIconChannel.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/icon/win/nsIconChannel.cpp,v  <-- 
nsIconChannel.cpp
new revision: 1.31; previous revision: 1.30
done

Comment 6

[Patrick]

*** Bug 233503 has been marked as a duplicate of this bug. ***

Comment 7

[Patrick]

*** Bug 232000 has been marked as a duplicate of this bug. ***

Comment 8

[Patrick]

*** Bug 230362 has been marked as a duplicate of this bug. ***