235617 - CERT_DecodeTrustString crashes if either input arg is NULL

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

This bug is shown by the same test program used in bug 39495.
Patch forthcoming.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

This patch detects NULL pointers and returns error SEC_ERROR_INVALID_ARGS, but
it still initializes the trust flags to zero, if it can.

Comment 2

[Wan-Teh Chang]

Comment on attachment 142268 [details] [diff] [review]
patch v1

r=wtc.

Can we test for both a null 'trust' and a null 'trusts'
at the beginning of the function, before we start to
set trust->xxxFlags to 0?  That is:

+    if (!trust || !trusts) {
+	PORT_SetError(SEC_ERROR_INVALID_ARGS);
+	return SECFailure;
+    }
     trust->sslFlags = 0;
     trust->emailFlags = 0;
     trust->objectSigningFlags = 0;

Comment 3

[Wan-Teh Chang]

Comment on attachment 142268 [details] [diff] [review]
patch v1

OK, I saw that you did that intentionally.

My previous comment showed that the new code
will be prone to mistakes by a future maintainer.
I expect that a function has no side effect if
it fails.  If that's not the case, I guess we
can document it...

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

I coded it this way so that the trust flags would get initialized, even
if nothing else happened.

/cvsroot/mozilla/security/nss/lib/certdb/certdb.c,v  <--  certdb.c
new revision: 1.64; previous revision: 1.63