235695 - nsMIMEInfoImpl and subclasses don't need two ctors

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P3)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

instead of:
nsMIMEInfoImpl()
and
nsMIMEInfoImpl(const char*)

this would suffice:
nsMIMEInfoImpl(const char* type = "");

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch (checked in)

I decided to inline the subclasses' ctor too, as it just calls the superclass
ctor anyway.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 142384 [details] [diff] [review]
patch (checked in)

r=bzbarsky

Comment 3

[Darin Fisher]

Comment on attachment 142384 [details] [diff] [review]
patch (checked in)

sr=darin

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 142384 [details] [diff] [review]
patch (checked in)

ok... this is checked in now, but it turns out I forgot nsMIMEInfoImpl; and I
can also make this ctor NS_HIDDEN. new patch coming.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 143107 [details] [diff] [review]
patch

r=bzbarsky

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

second patch checked in

Checking in nsMIMEInfoImpl.h;
/cvsroot/mozilla/uriloader/exthandler/nsMIMEInfoImpl.h,v  <--  nsMIMEInfoImpl.h
new revision: 1.20; previous revision: 1.19
done


all done