Closed Bug 235730 Opened 20 years ago Closed 20 years ago

Error when trying to log in

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: pavel1r, Unassigned)

References

()

Details

(Keywords: regression)

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:) Gecko/20040225

When I'm trying to log in on http://www.hpdevelopersolutions.com/join/APDK.cfm
nothing happens and there is an error on Javascript console: "Error: Login is
not defined
Source File: http://www.hpdevelopersolutions.com/join/APDK.cfm
Line: 711"

This used to work just a few days (builds) ago, and works in Mozilla Firefox 0.8

Reproducible: Always
Steps to Reproduce:
1. Go to http://www.hpdevelopersolutions.com/join/APDK.cfm
2. Try to log in. (free registration needed to log in successfully)
3.

Actual Results:  
Nothing happens + error in JS console.

Expected Results:  
To perform a login.
This has nothing to do with the JS engine.

It's a regression from bug 147058 -- the page uses a raw "Login" in that event
handler which works in IE due to its window.name thing and which worked in
Mozilla due to the scope chain walk we did.  But then we removed the scope chain
walk....
Assignee: general → general
Status: UNCONFIRMED → NEW
Component: JavaScript Engine → DOM: Level 0
Ever confirmed: true
Keywords: regression
OS: Windows 2000 → All
QA Contact: pschwartau → ian
Hardware: PC → All
Summary: Error when trying to log in → Error when trying to log in
I thought the intention was to walk directly to the document, which does have
the Login property sought...
This has nothing to do with DOM object scoping, the code uses an onsubmit
handler that calls a global function, and in the global function, which'll run
in the global scope, it references Login, which isn't defined. That never worked
in Mozilla, the reason the site worked was that the onsubit handler fails, and
we used to submit even if there were errors in the onsubmit handlers, we no
longer do that (see bug 233142, and there's another bug about this specific
functionality too, but I don't have the number handy).

So I guess the big question is, is this what we want, or do we want to keep
submitting on errors in onsubmit?
Define "errors" -- you mean, if an exception is raised?

We should submit if the event is not cancelled. Do errors/exceptions cancel
running events?
Yeah, exceptions... bz, remember what that onsubmit bug was, the one about not
submitting if exceptions are raised in the onsubmit handler?
I just backed out the part of the fix for bug 233142 that caused this. Marking
this FIXED.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
jst: bug 134878.  (Found it again by using the "collect buglinks" bookmarklet in
bug 233142.)
It helps to cc me when asking me a question... ;)
D'oh.
You need to log in before you can comment on or make changes to this bug.