235735 - fix callers that cast away const on result of ns[C]String::get

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://lxr.mozilla.org/seamonkey/search?string=NS_CONST_CAST%28char
http://lxr.mozilla.org/seamonkey/search?string=NS_CONST_CAST%28PRUnichar

plus the C-style casts

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[Darin Fisher]

Comment on attachment 142376 [details] [diff] [review]
patch

> +         * deperecated reading iterators
> +        grabArgs(cargs.BeginWritnig(), &args);

r+sr=darin with those two typos fixed.

i've also added a fix for the requestURI munging in nsHttpChannel.  in that
case, a |const char*| is later cast to |char*| so the 'greping' didn't detect
it.  i fear there may be others like this :(

Comment 4

[Darin Fisher]

patch checked in

thx dbaron!!!