235747 - Move parser stuff into mozilla/parser

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Peter Van der Beken [:peterv]]

We want to move mozilla/expat into mozilla/parser/expat and mozilla/htmlparser
into mozilla/parser/htmlparser. As soon as the cvs copies are done I'll attach
the necessary build/code changes here.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

err.. what's happening here? Right now we're having two forks which seems like a
very bad idea.

Comment 2

[Peter Van der Beken [:peterv]]

I'm not going to do this during the freeze but unfortunately the repository
copies happened just before the start of the freeze. I'll handle the forks until
I land the makefile changes, shouldn't be too big a deal.

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1 (without the allmakefiles.sh changes)

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 147448 [details] [diff] [review]
v1 (without the allmakefiles.sh changes)

The allmakefiles.sh changes are in the gzipped patch (attachment 147447 [details]). I
replaced every occurence of expat with parser/expat and htmlparser with
parser/htmlparser.

Comment 6

[Alex Vincent [:WeirdAl]]

Nit:

+include $(DEPTH)/config/autoconf.mk
+
+DIRS            = expat \
+                  htmlparser
+
+include $(topsrcdir)/config/rules.mk

Everywhere else, a DIRS listing has a backslash after it.  Is it missing from 
htmlparser deliberately here?

Comment 7

[Peter Van der Beken [:peterv]]

I'll just put them on one line if it bothers you.

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 147448 [details] [diff] [review]
v1 (without the allmakefiles.sh changes)

sr=jst

Check it in! Check it in! :-)

Comment 9

[Justin Wood (:Callek)]

the DIRS from my understanding had stuff like in all other makefiles

(manually going from coment #6

+DIRS            = expat \
+                  htmlparser
+

where in actuality it would look like

+DIRS            = expat \
+                  htmlparser\
+                  ${NULL}

to make adding in extra DIRS easy(ier).  though some makefiles have it all on
one line also.

Comment 10

[Peter Van der Beken [:peterv]]

Checked in, old files removed.

Comment 11

[timeless]

peterv: the preferred way to use DIRS is the second form justin cited in comment 9.

the reason is so that you can add or remove an item from the list without taking
blame for the entire list.