235797 - bookmarks.html permissions always reset to 600

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Felix Miata]

I see this on Mandrake 10b, SuSE 8.2, and Fedora Core 1, with 1.4.1, 1.6, and
current trunk.

I have several profiles for several versions of Mozilla, but I never run more
than one at a time. I want each to use the very same bookmarks.html file,
regardless whether by link or by the hidden pref to use a particular file in a
particular location. The only way this can work properly is with perms set to
664 or 660, so it isn't working now. Whichever profile owns the file is the only
one allowed to write it. If I set ownership to the actual group owner, which is
not a login owner, no profile ever can write it. If leaving the perms as it
finds them can't be the default setting, then it at least should be possible via
pref.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is a bookmarks bug....

Comment 2

[timeless]

Attachment: copy permissions

if the move fails, then in certain cases it fails while overwriting the
bookmarks file, this means that the bookmarks file is invalid/lost. there is
only one complete bookmarks file left, it's in a temporary file. killing that
complete bookmarks file is imo not very nice(tm), hence the ifdef. that change
is of course negotiable.

permissions accesses are not part of the critical path, so their rvs are not
fatal to the function.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 142429 [details] [diff] [review]
copy permissions

sr=bzbarsky

Comment 4

[Benjamin Smedberg]

Comment on attachment 142429 [details] [diff] [review]
copy permissions

r=me if it works

Comment 5

[timeless]

mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp 	1.307