235815 - Improve button labels for Confirm Password Change dialog

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Logan Ingalls]

User-Agent:       
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040219 Firefox/0.8.0+

When you have a form that the password manager fills in for you, and you change
the password field and then submit, sometimes you get a dialog:

 -------------------------------------------------
|             Confirm Password Change             |
|-------------------------------------------------|
| Would you like to have Password Manager change  |
| the stored password for Plutor?                 |
|                                                 |
|                              [ Cancel ] [ OK ]  |
 -------------------------------------------------

Since clicking cancel does not _cancel_ the form submit, it's probably a bad
choice of words.  "Yes" and "No" would probably be better.

(I should probably submit another bug saying that I only get this dialog on
certain sites, one of which is when updating my profile on geocaching.com.  Can
anyone explain why this is?)

Reproducible: Sometimes
Steps to Reproduce:


Actual Results:  
"Cancel" and "OK" buttons

Expected Results:  
"No" and "Yes" buttons

Comment 1

[Logan Ingalls]

Okay, I figured out why the dialog doesn't always come up.  Mozilla doesn't
prompt unless it considers the current page to be a "change password page" with
a few reasonable criteria.

But the button labels are still awkward.

Comment 2

[Logan Ingalls]

Attachment: Patch to use ConfirmEx() instead of Confirm()

This is my first ever Mozilla patch.  I'm excited, the source code was much
easier to understand than I expected.  LXR is my friend.

Comment 3

[David P James]

Not sure why this bug was reclassed as an enhancement since the current 
implementation is confusing (eg buggy). Enhancements are feature requests for 
something that doesn't currently exist or to improve the way an existing 
working feature/function works. 
 
-->Confirmed 
-->Trivial 

Comment 4

[David P James]

Comment on attachment 142741 [details] [diff] [review]
Patch to use ConfirmEx() instead of Confirm()

Brian: Can you take a look at this? Is superreview required on this as well?
Blake maybe?

Comment 5

[Logan Ingalls]

Attachment: Patch v2

I apologize for my first sloppy patch, especially the bad file paths and
inadequate context.

Comment 6

[Mike Connor [:mconnor]]

checked in branch and trunk 2004-05-02 10:32

thanks for the patch!