Closed
Bug 235887
Opened 20 years ago
Closed 20 years ago
Add .win, .mac, .pc and .unix classes to show platform-specific help content
Categories
(SeaMonkey :: Help Documentation, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rjkeller, Assigned: rjkeller)
Details
Attachments
(1 file, 6 obsolete files)
1.86 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
The problem with help now is that when we have lines that say: "To do x, click on File (Mozilla menu on MacOS) and select y", it shows information on both platforms. We should say: "To do x, click on <pc>File</pc><mac>Mozilla menu</mac> and select y", where pc would be displayed on Windows/Unix, and mac would be displayed on Mac. We would also have <unix> and <win> in case we're dealing with Keyboard Shortcuts. It'd be much easier to the user and reduce the amount of reading needed.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Comment 2•20 years ago
|
||
Comment on attachment 142483 [details] [diff] [review] Patch - CSS only Neil can you review this? This is only the CSS part. The help docs update will come later.
Attachment #142483 -
Attachment description: Patch → Patch - CSS only
Attachment #142483 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Comment 3•20 years ago
|
||
Uses display: none; instead of visibility: hidden;, and implements attributes (meaning, you can have <mac display="false"> to hide content for Mac users).
Attachment #142483 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #142483 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Updated•20 years ago
|
Attachment #142492 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 4•20 years ago
|
||
User documentation serve average users as well as advanced users. If you are a tech support, it is useful to be able to see differences between platforms. I don't see how occassional (for platform XXX do YYY) is any clutter.
Assignee | ||
Comment 5•20 years ago
|
||
yeah, but some areas of help it gets a bit crazy. Not only that, Mac users have the frustration that there are a lot of times where the mac way isn't shown or maybe don't see it right away. My biggest issue with this is keyboard shortcuts in Help files. There are a lot of cases where they are totally different depending on the OS.
Status: NEW → ASSIGNED
Comment 6•20 years ago
|
||
Comment on attachment 142492 [details] [diff] [review] Patch - CSS only - uses display instead of visibility If you put this in the xhtml it won't validate. Perhaps you could use classes e.g. .not.win, .mac, .unix { display: none; }
Assignee | ||
Updated•20 years ago
|
Attachment #142492 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Comment 7•20 years ago
|
||
Attachment #142492 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #142647 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 8•20 years ago
|
||
BDS, please could you give me a quick rundown of the pros and cons of using the preprocessor vs. using separate platform-specific CSS files?
Comment 9•20 years ago
|
||
If CSS works for this platform-specific stuff, let's use it. In general, we should only be using the preprocessor when we need global variable substitutions or need to apply platform-specific overlays.
Comment 10•20 years ago
|
||
Comment on attachment 142647 [details] [diff] [review] Patch - uses classes instead of actual tags. >+mac, win, unix { display: none; } I think you missed the dots off here, but I don't see the point of mucking about with multiple styles, use e.g. .notMac, .win, .unix { display: none; }
Attachment #142647 -
Flags: review?(neil.parkwaycc.co.uk) → review-
Assignee | ||
Comment 11•20 years ago
|
||
Neil: The reason is because what if we wanted to display something for Linux, Windows, etc. but not for MacOS? This seems to be the only way. We could do a .pc, but I think there are some cases where this happens for linux instead of MacOS, so it would be useful.
Comment 12•20 years ago
|
||
No, I meant just put separate versions of all the rules inside #if blocks, don't try to combine rules between platforms.
Assignee | ||
Comment 13•20 years ago
|
||
Attachment #142647 -
Attachment is obsolete: true
Assignee | ||
Comment 14•20 years ago
|
||
This is a patch incorporating some feedback I got on IRC.
Assignee | ||
Updated•20 years ago
|
Attachment #142711 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #142956 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Comment 15•20 years ago
|
||
Attachment #142956 -
Attachment is obsolete: true
Assignee | ||
Comment 16•20 years ago
|
||
Attachment #143143 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #143145 -
Flags: review?(neil.parkwaycc.co.uk)
Updated•20 years ago
|
Attachment #143145 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #142956 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Comment 17•20 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Summary: Add <win>, <mac>, <pc>, and <unix> tags to show platform-specific help content → Add .win, .mac, .pc and .unix classes to show platform-specific help content
Updated•20 years ago
|
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•