235897 - <iframe src=file:///non-existent> does not refresh its background

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P1)

Description

[Mats Palmgren (inactive)]

The background of an <iframe> which fails to load does not refresh
its background.

STEPS TO REPRODUCE:
1. Load the testcase (click OK in the error dialog)
2. Click on "File" in the browser menubar
3. Move the mouse over the menubar, opening/closing menus over the <iframe>

ACTUAL RESULTS:
The <iframe> background display random pixel values.

EXPECTED RESULTS:
The <iframe> background should be repainted.

BUILDS & PLATFORMS TESTED:
Bug occurs in Mozilla nightly trunk build 2004-02-26-08 on Linux
Bug occurs in Mozilla 1.6, 1.4.1, 1.2.1 and 1.0.2

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 2

[Mats Palmgren (inactive)]

Aha, I see now that it only occurs for file: URIs

Comment 3

[Mats Palmgren (inactive)]

Attachment: Screenshot

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I have a feeling this is a dup. but I'll take it.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

When the file: URL fails to load, the native widget for the root of the
IFRAME's document stays hidden. The view manager doesn't notice that it's
hidden and when painting the widgets under it, includes the hidden widget's
area as part of the area covered by opaque widgets that should be skipped. So
the views "under" the hidden widget are not painted and the backbuffer is
copied straight to the screen, and it contains garbage.

The solution is to not add the areas of hidden widgets to the "opaque covering"
region.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 145006 [details] [diff] [review]
fix

another nice simple fix :-)

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 145006 [details] [diff] [review]
fix

r+sr=dbaron, assuming a |diff -ub| shows that you're just adding the
childWidget->IsVisible check.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm going to hold this over for 1.8a unless someone (Mats) convinces me otherwise.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Could this be responsible for the flashes of garbage bryner and I have been
noticing recently?  I think it would be good to get this in for 1.7 -- it
certainly doesn't seem risky.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

dbaron: yes, it's possible

Comment 11

[Mike Kaply [:mkaply]]

Comment on attachment 145006 [details] [diff] [review]
fix

a=mkaply

This is a very small fix - a -w diff would make that clearer.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

fix checked in.