Closed
Bug 236010
Opened 21 years ago
Closed 21 years ago
INI parser reads memory beyond EOF
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
Details
Attachments
(1 file)
|
1.09 KB,
patch
|
benjamin
:
review+
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
valgrind spews a lot of these:
strchr (mac_replace_strmem.c:113)
nsINIParser::FindKey(char*, char*, char*, int*) (nsINIParser.cpp:245)
nsINIParser::GetString(char*, char*, char*, int*) (nsINIParser.cpp:108)
nsINIParser::GetStringAlloc(char*, char*, char**, int*) (nsINIParser.cpp:122)
Address 0x58EE18A is 0 bytes after a block of size 3238 alloc'd
malloc (vg_replace_malloc.c:160)
nsINIParser::nsINIParser(char*) (nsINIParser.cpp:59)
nsXIContext::LoadResources() (nsXIContext.cpp:137)
nsXInstaller::ParseConfig() (nsXInstaller.cpp:95)
the file is read into a buffer just big enough for its contents. There is no
room for NULL termination.
|
Assignee | |
Comment 1•21 years ago
|
||
allocate (eofpos+1) chars, and null-terminate mFileBuf.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #142581 -
Flags: review?(bsmedberg)
|
||
Updated•21 years ago
|
Attachment #142581 -
Flags: review?(bsmedberg) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #142581 -
Flags: superreview?(dveditz+bmo)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 142581 [details] [diff] [review]
patch
sr=dveditz
Attachment #142581 -
Flags: superreview?(dveditz+bmo) → superreview+
|
|
Assignee | |
Comment 3•21 years ago
|
||
checked in by mconner
marking FIXED
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•