236026 - In <FilterListDialog.js>, "Warning: redeclaration of var item"

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219] (W98SE)

{
Warning: redeclaration of var item
Source File: chrome://messenger/content/FilterListDialog.js
Line: 159, Column: 8
Source Code:
    var item = event.target;
}

Testcase:
1. MailNews > Tools > Message Filters...

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <FilterListDialog.js>

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1b) <FilterListDialog.js>

Av1, totally revised.

Comment 3

[[e-mail]]

Comment on attachment 142602 [details] [diff] [review]
(Av1b) <FilterListDialog.js>

>diff -u -p -r1.52 FilterListDialog.js
This patch seems to change the indentation of some lines but not others... if
you meant to change the indentation, then you should provide two patches, one
showing the new indentation and one with the extra -w option to diff showing
only the changes that are not indentation.

>+  var itemId = event.target.id;
It might be an idea to use a slightly more meaningful variable name e.g.
itemURI

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) <FilterListDialog.js> [Checked in: Comment 7]

Av1b, with comment 3 suggestion(s).

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 143182 [details] [diff] [review]
(Av2) <FilterListDialog.js>
[Checked in: Comment 7]


Keeping { (Av1b) <FilterListDialog.js>		 patch		2004-02-29
08:03 PST    neil.parkwaycc.co.uk: review+ }

Comment 6

[chris hofmann]

Comment on attachment 143182 [details] [diff] [review]
(Av2) <FilterListDialog.js>
[Checked in: Comment 7]

a=chofmann for 1.7b

Comment 7

[[e-mail]]

Fix checked in.