236101 - Flatten the embedding SDK

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Packaging, defect)

Description

[Benjamin Smedberg]

As we talked about on the newsgroups a while back, I want to "flatten" the
directory structure of the mozilla SDK. Instead of module names, there would be
only a few folders:

[sdk]/include
[sdk]/lib
[sdk]/bin
[sdk]/idl

This makes life much easier for embedders, because they don't have to set up a
giant list of include directories. Already got approval from
dougt/blizzard/adamlock.

Comment 1

[Benjamin Smedberg]

Attachment: Flatten the SDK directory structure

Comment 2

[cls]

Comment on attachment 142675 [details] [diff] [review]
Flatten the SDK directory structure

Yay, a sane sdk layout.    

Just 2 minor nits:
1) You're removing the build-list.pl commands which are used to purge old
headers out of the sdk include directories.  Granted, the list is currently
being placed in the wrong directory so the old headers aren't being purged
anyway but we should either rm-rf dist/sdk at the beginning of each build or
keep the list updated.

2) You're installing the shared libs into sdk/lib which is fine for unix builds
but kills win32 as they expect the dlls to be in the PATH or cwd. 

Fix those && r=cls

Comment 3

[Benjamin Smedberg]

Attachment: updated per cls

I meant to get to this earlier :(  I would still like to get this in for 1.7,
if possible... it won't affect the seamonkey distros, only the SDK tarballs.

Comment 4

[Benjamin Smedberg]

Comment on attachment 144319 [details] [diff] [review]
updated per cls

Carrying over review, requesting 1.7+

Comment 5

[cls]

Comment on attachment 144319 [details] [diff] [review]
updated per cls

In the toplevel makefile, that should be $(DIST)/sdk not dist/sdk .

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 144319 [details] [diff] [review]
updated per cls

a=mkaply

Comment 7

[Benjamin Smedberg]

checked in for 1.7final