Closed Bug 236101 Opened 20 years ago Closed 20 years ago

Flatten the embedding SDK

Categories

(Core Graveyard :: Embedding: Packaging, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7final

People

(Reporter: benjamin, Assigned: benjamin)

Details

(Keywords: embed)

Attachments

(1 file, 1 obsolete file)

As we talked about on the newsgroups a while back, I want to "flatten" the
directory structure of the mozilla SDK. Instead of module names, there would be
only a few folders:

[sdk]/include
[sdk]/lib
[sdk]/bin
[sdk]/idl

This makes life much easier for embedders, because they don't have to set up a
giant list of include directories. Already got approval from
dougt/blizzard/adamlock.
Attachment #142675 - Flags: review?(cls)
Comment on attachment 142675 [details] [diff] [review]
Flatten the SDK directory structure

Yay, a sane sdk layout.    

Just 2 minor nits:
1) You're removing the build-list.pl commands which are used to purge old
headers out of the sdk include directories.  Granted, the list is currently
being placed in the wrong directory so the old headers aren't being purged
anyway but we should either rm-rf dist/sdk at the beginning of each build or
keep the list updated.

2) You're installing the shared libs into sdk/lib which is fine for unix builds
but kills win32 as they expect the dlls to be in the PATH or cwd. 

Fix those && r=cls
Attachment #142675 - Flags: review?(cls) → review+
Attached patch updated per clsSplinter Review
I meant to get to this earlier :(  I would still like to get this in for 1.7,
if possible... it won't affect the seamonkey distros, only the SDK tarballs.
Attachment #142675 - Attachment is obsolete: true
Comment on attachment 144319 [details] [diff] [review]
updated per cls

Carrying over review, requesting 1.7+
Attachment #144319 - Flags: review+
Attachment #144319 - Flags: approval1.7?
Comment on attachment 144319 [details] [diff] [review]
updated per cls

In the toplevel makefile, that should be $(DIST)/sdk not dist/sdk .
Comment on attachment 144319 [details] [diff] [review]
updated per cls

a=mkaply
Attachment #144319 - Flags: approval1.7? → approval1.7+
checked in for 1.7final
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7final
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: