236202 - caption should inherit all font properties in quirks mode

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Harshal Pradhan]

quirk.css explicitly cuts of inheritance of font stuff for <caption>s.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/html/document/src/quirk.css&rev=1.43&mark=101-108#100

This does not match what IE 6.0 or Opera 7.2 do.
Is mozilla better off without the quirk?

Comment 1

[Harshal Pradhan]

Attachment: Testcase

Comment 2

[Harshal Pradhan]

Attachment: Obvious patch

Comment 3

[Bernd]

Harshal give me aday or two to review this, the difficult part is why we had
this in our code base.

Comment 4

[Bernd]

Comment on attachment 142744 [details] [diff] [review]
Obvious patch 

r=bernd if you join the two adjacent table sections. I think hyatt was to eager
with the font inheritance cut. I did rtest it, we dont have a testcase that
relies on the quirk and the NN font style handling for tables  is sooo broken
that we should more focus on IE. David could you please sr ? You did review 
bug 78695, so you might remember why have the caption inheritance cut, in my
opinion it can go away.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 142744 [details] [diff] [review]
Obvious patch 

I didn't review bug 78695 -- attinasi, waterson, and jst did.  I did comment on
the few parts of the patch I was able to look at at the time...

Comment 6

[Bernd]

>I did comment on the few parts of the patch I was able to look at at the time...
If that is not understatement, I dont know what it is.

Comment 7

[Harshal Pradhan]

Attachment: Updated patch

Thanks for the testing and the reviews. 

This patch just had the adjacent table sections merged into a single one per
Bernd.

Comment 8

[Harshal Pradhan]

Checked in. 

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Re comment 8: In addition to comments on building the branch, the only comments
I made about the changes (bug 78695 comment 35, bug 78695 comment 36, bug 78695
comment 140) were on things in the central header file that was changed.  The
patch was landed with "r/sr=attinasi, jst, waterson".  I didn't get a chance to
understand how the stuff worked until I was working on bug 83958 the following
month.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 143258 [details] [diff] [review]
Updated patch

The comment delimiters in this patch are bad.  I'll fix them.

Comment 11

[Harshal Pradhan]

(In reply to comment #10)
> (From update of attachment 143258 [details] [diff] [review])
> The comment delimiters in this patch are bad.  I'll fix them.
> 

D'oh! Sorry for the brain fart. I should have been more careful. 

Thanks for fixing it up.