Closed
Bug 236202
Opened 20 years ago
Closed 20 years ago
caption should inherit all font properties in quirks mode
Categories
(Core :: Layout: Tables, defect)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
People
(Reporter: keeda, Assigned: keeda)
Details
Attachments
(2 files, 1 obsolete file)
510 bytes,
text/html
|
Details | |
1.39 KB,
patch
|
dbaron
:
review-
|
Details | Diff | Splinter Review |
quirk.css explicitly cuts of inheritance of font stuff for <caption>s. http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/html/document/src/quirk.css&rev=1.43&mark=101-108#100 This does not match what IE 6.0 or Opera 7.2 do. Is mozilla better off without the quirk?
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Comment 2•20 years ago
|
||
Harshal give me aday or two to review this, the difficult part is why we had this in our code base.
Comment on attachment 142744 [details] [diff] [review] Obvious patch r=bernd if you join the two adjacent table sections. I think hyatt was to eager with the font inheritance cut. I did rtest it, we dont have a testcase that relies on the quirk and the NN font style handling for tables is sooo broken that we should more focus on IE. David could you please sr ? You did review bug 78695, so you might remember why have the caption inheritance cut, in my opinion it can go away.
Attachment #142744 -
Flags: superreview?(dbaron)
Attachment #142744 -
Flags: review+
Comment on attachment 142744 [details] [diff] [review] Obvious patch I didn't review bug 78695 -- attinasi, waterson, and jst did. I did comment on the few parts of the patch I was able to look at at the time...
Attachment #142744 -
Flags: superreview?(dbaron) → superreview+
>I did comment on the few parts of the patch I was able to look at at the time...
If that is not understatement, I dont know what it is.
Assignee | ||
Comment 7•20 years ago
|
||
Thanks for the testing and the reviews. This patch just had the adjacent table sections merged into a single one per Bernd.
Assignee | ||
Comment 8•20 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Re comment 8: In addition to comments on building the branch, the only comments I made about the changes (bug 78695 comment 35, bug 78695 comment 36, bug 78695 comment 140) were on things in the central header file that was changed. The patch was landed with "r/sr=attinasi, jst, waterson". I didn't get a chance to understand how the stuff worked until I was working on bug 83958 the following month.
Comment on attachment 143258 [details] [diff] [review] Updated patch The comment delimiters in this patch are bad. I'll fix them.
Attachment #143258 -
Flags: review-
Assignee | ||
Comment 11•20 years ago
|
||
(In reply to comment #10) > (From update of attachment 143258 [details] [diff] [review]) > The comment delimiters in this patch are bad. I'll fix them. > D'oh! Sorry for the brain fart. I should have been more careful. Thanks for fixing it up.
You need to log in
before you can comment on or make changes to this bug.
Description
•