236208 - lastPageVisited isn't idn-safe

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[[e-mail]]

History URLs are stored as UTF-8 but lastPageVisited is declared as a string so
it cannot return UTF-8 data. I suggest it is changed to AUTF8String instead.

Steps to reproduce problem:
1. Configure one of your navigator startup prefs to last page visited
2. Visit the URL
3. Open navigator in such a way as to trigger the pref

Expected results: URL opens

Actual results: Mozilla tries to load http://öko.de/

Comment 1

[[e-mail]]

Attachment: Work in progress

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

I vote for nsIURI

Comment 3

[[e-mail]]

OK, so bug 236138 fixed this for the case of retrieving the browser's idea of
the startup page from the last page visited, so all I need to do now is to fix
access to lastPageVisited from script.

Comment 4

[[e-mail]]

Attachment: Proposed patch

Comment 5

[[e-mail]]

OK, let's try again in UTF-8 ...
Steps to reproduce problem:
1. Configure Mozilla to load the last page visited in a new window
2. Open http://öko.de/
3. Open a new browser window

Actual results: Mozilla tries to load http://öko.de/

Note that the new tab case has slightly different code - it actually duplicates
the current tab, rather than loading the last page visited. And bsmedberg fixed
the navigator startup case in bug 236138.

Comment 6

[Alec Flett]

Comment on attachment 142825 [details] [diff] [review]
Proposed patch

in nsBrowserInstance, use nsCAutoString, not nsCString

other than that, sr=alecf

Comment 7

[[e-mail]]

Fix checked in.