236269 - --enable-trace-malloc is broken

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[timeless]

my mozconfigs have:

ac_add_options --enable-trace-malloc

The build fails linking layout.

Comment 1

[timeless]

Attachment: Link against tracemalloc

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

What's the error?

Comment 3

[timeless]

Building deps for /cygdrive/r/mozilla/layout/build/nsContentHTTPStartup.cpp
nsContentHTTPStartup.cpp
LINK : warning LNK4224: /PDB:NONE is no longer supported;  ignored
   Creating library gklayout.lib and object gklayout.exp
LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs;
use /NODEFAULTLIB:library
jsdombase_s.lib(nsJSEnvironment.obj) : error LNK2019: unresolved external symbol
_NS_TraceMallocDisable referenced in fu
nction "int __cdecl TraceMallocDisable(struct JSContext *,struct JSObject
*,unsigned int,long *,long *)" (?TraceMallocDi
sable@@YAHPAUJSContext@@PAUJSObject@@IPAJ2@Z)
jsdombase_s.lib(nsJSEnvironment.obj) : error LNK2019: unresolved external symbol
_NS_TraceMallocEnable referenced in fun
ction "int __cdecl TraceMallocEnable(struct JSContext *,struct JSObject
*,unsigned int,long *,long *)" (?TraceMallocEnab
le@@YAHPAUJSContext@@PAUJSObject@@IPAJ2@Z)
jsdombase_s.lib(nsJSEnvironment.obj) : error LNK2019: unresolved external symbol
_NS_TraceMallocChangeLogFD referenced i
n function "int __cdecl TraceMallocChangeLogFD(struct JSContext *,struct
JSObject *,unsigned int,long *,long *)" (?Trace
MallocChangeLogFD@@YAHPAUJSContext@@PAUJSObject@@IPAJ2@Z)
jsdombase_s.lib(nsJSEnvironment.obj) : error LNK2019: unresolved external symbol
_NS_TraceMallocCloseLogFD referenced in
 function "int __cdecl TraceMallocCloseLogFD(struct JSContext *,struct JSObject
*,unsigned int,long *,long *)" (?TraceMa
llocCloseLogFD@@YAHPAUJSContext@@PAUJSObject@@IPAJ2@Z)
jsdombase_s.lib(nsJSEnvironment.obj) : error LNK2019: unresolved external symbol
_NS_TraceMallocLogTimestamp referenced
in function "int __cdecl TraceMallocLogTimestamp(struct JSContext *,struct
JSObject *,unsigned int,long *,long *)" (?Tra
ceMallocLogTimestamp@@YAHPAUJSContext@@PAUJSObject@@IPAJ2@Z)
jsdombase_s.lib(nsJSEnvironment.obj) : error LNK2019: unresolved external symbol
_NS_TraceMallocDumpAllocations referenc
ed in function "int __cdecl TraceMallocDumpAllocations(struct JSContext *,struct
JSObject *,unsigned int,long *,long *)"
 (?TraceMallocDumpAllocations@@YAHPAUJSContext@@PAUJSObject@@IPAJ2@Z)
gklayout.dll : fatal error LNK1120: 6 unresolved externals
make[1]: *** [gklayout.dll] Error 96

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 142794 [details] [diff] [review]
Link against tracemalloc

How about just doing what the old dom/src/build/Makefile.in did, which is:

ifdef NS_TRACE_MALLOC
EXTRA_DSO_LIBS	+= tracemalloc
endif

Comment 5

[timeless]

Attachment: per dbaron

Comment 6

[timeless]

mozilla/layout/build/Makefile.in 	1.107