236438 - Wrong x/y values sent on image button (input[type=image])

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[HARUNAGA Hirotoshi]

Recent build sends wrong x/y coordinate values on image button
(input[type=image]).

Steps:
1. Load http://maps.yahoo.com/maps_result?ed=M7tNO.p_0TqT&csz=new+york&country=us
2. Click around "Broadway" inside the map.

Result:
"Atlantic Ocean".

Confirmed with 2004022909/WinNT and 2004030205/Mac.
1.6 doesn't have this problem.
regression.

See also testcase in the URL above.
(Save the testcase to disk, and open)
It seems that Mozilla sends coordinates inside the window,
instead of inside the image...

Comment 1

[HARUNAGA Hirotoshi]

2004022805 has no problem, 2004022905 is broken.

Comment 2

[Mats Palmgren (inactive)]

Backing out bug 53966 fixes this.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

eek

Comment 4

[Boris Zbarsky [:bzbarsky]]

I bet adding a call to nsImageFrame::TranslateEventCoords at
http://lxr.mozilla.org/seamonkey/source/layout/html/forms/src/nsImageControlFrame.cpp#266
fixes this.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Indeed, you're right.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Mm... and the old code was buggy with borders too, eh?  ;)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 142972 [details] [diff] [review]
fix

r+sr=bzbarsky

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in.

Comment 9

[Mats Palmgren (inactive)]

Verified fixed, 2004-03-06-09 trunk Linux.