236446 - Fix for windows activation endless loop

Status: RESOLVED FIXED

(Core Graveyard :: GFX: BeOS, defect)

Description

[Sergei Dolgov]

There is awful issue rising in our port from time to time, depemding on changes
of focus control in upper layers of code - Window activation race. When windows
tend to fail into infinite loop of activation. Especially annoying for people
who don't know that Mozilla has tabbed browsing.

Mostly it is caused by multithreaded nature of BeOS windowing, way it is
workarounded in native thread disliking mozilla and very long message
pass-through - from BeAPI hook via CallMethodAsync to mozilla-messagging and
not-so effective port-queue to mozilla view-control layers and back to widget code.
So there is big chance to that just deactivated by e.g. user action window just
gets SetFocus command (which activates it again)

Fix looked quite simple, in CallMethod() in
case nsWindow::ONACTIVATE:
just add check before invoking DispatchFocus()
if mView->Window->IsActive() or vice versa, depending on message.

Comment 1

[Sergei Dolgov]

Attachment: patch (diff -up)

simple patch.

Way to test before and after patch.
(Better in Focus Follow Mouse mode, but simple mode works too)
Open Mozilla, then start fast (without waiting for opening previously clicked
component) clicking on components icons in left bottom corner. Also try to
click fastly forth and back on yellow tabs of rising windows or/and move mose
over if in FFM mode.
Result before patch - windows fall in infinite activation loop.
Expected result of patch - no endless loop.

Comment 2

[Sergei Dolgov]

Comment on attachment 142949 [details] [diff] [review]
patch (diff -up)

review request

Comment 3

[Simon]

Comment on attachment 142949 [details] [diff] [review]
patch (diff -up)

r=[e-mail]

Works well for me.

Comment 4

[Sergei Dolgov]

Comment on attachment 142949 [details] [diff] [review]
patch (diff -up)

reviewed, no sr-required (port-only code in port-specific folder)

Comment 5

[Sergei Dolgov]

Patch commited:
"[BeOS] bug 236446 Fix for windows activation endless loop, review=simontaylor2,
no sr required(port-only), approval=dbaron"
Marking bug fixed