236484 - menus in menubar still painted as active after popup is dismissed

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Pierre Chanial]

Step to reproduce with a fresh gtk2 build:
- click on a menubar menu
- click outside the popup

expected: menubar menu state is back to normal
current: it is still active...

This bug has been revealed by the skin simplifications I've done in menu.css,
popup.css in skin/gtk2. It did not appear when we were using the files in
skin/win (with the menuitem appearance enabled...) that I have now backed out.

Comment 1

[Pierre Chanial]

-> 0.9

Comment 2

[Pierre Chanial]

Attachment: another manifestation

Comment 3

[Pierre Chanial]

This bug appeared after I removed all the references to the attribute
"_moz-menuactive" in menu.css. In nsITheme, this attribute controls the state of
the menu item gtk widget.
What happens is that the style system has no rule involving "_moz-menuactive"
and doesn't take into account its changes.
Problem goes away when I add a dummy rule:
 menuitem, menu { border-color:transparent;}
even if this rule is superceded by the appearance...

I guess that a proper fix would involve getting rid of the attribute
"_moz-menuactive" and use the :active state.

Comment 4

[Pierre Chanial]

updating summary.
I checked in a workaround into skin/gtk2/menu.css:

 menu[_moz-menuactive="true"],
 menuitem[_moz-menuactive="true"] {
+  /* dummy rule to force repainting when _moz-menuactive changes */
+  border-color: transparent;
   /* color: HighlightText; should be fg[PRELIGHT] */
 }
  

Comment 5

[Boris Zbarsky [:bzbarsky]]

Um... Isn't this what we have WidgetStateChanged() for?  If it uses a magic
attribute, it should check it and return true accordingly.

Comment 6

[Pierre Chanial]

Awesome! patch in a sec

Comment 7

[Pierre Chanial]

Attachment: patch v1.0

I included also the "focused" attribute that controls the focus state of
textbox

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 142973 [details] [diff] [review]
patch v1.0

r+sr=bzbarsky, but in general you _do_ want to switch to using content state
changes for this, I would think...

I assume this magic attribute is gtk2-only and hence mac/win/whatever don't
need similar patches.

Comment 9

[Pierre Chanial]

(In reply to comment #8)

> I assume this magic attribute is gtk2-only and hence mac/win/whatever don't
> need similar patches.
yes

checked in.