236532 - download / sync stops working silently

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Backend, defect)

Description

[Michael Zimmermann]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113

I do have 4 mail accounts with about 30 folders and 20000 messages total. 3 of
these mail accounts are imap, the 4th is pop3. 

Because I wanted to make the message bodies available also on my mobile computer
I selected the important folders (i. e. all except of junk, trash) for all
accounts and then did File->Offline->Download/Sync now with "Go Offline after
download = true"

Mzilla starts downloading and stops after a short while. It doesn't go offline;
it doesn't download all mail headers and bodies. 

What I think it does is that it downloads all the content of the folder that was
selected when I did "Sync now".

Reproducible: Always
Steps to Reproduce:
1. Create some imap accounts and populate them with some messages
2. Select some folders for offline / download
3. Hit Offline / Sync Now

Actual Results:  
Not much, see above.

Expected Results:  
All the messages + headers should be downloaded to the computer

Comment 1

[krishna]

Dupe of bug 142278 ?

Comment 2

[Michael Zimmermann]

Ok, didn't find this one while searching for a duplicate. Sorry!

Marking this bug resolved and duplicate of bug 142278.

Any progress on bug 142278 ?

*** This bug has been marked as a duplicate of 142278 ***

Comment 3

[David :Bienvenu]

w/o a protocol log, marking this a dup of 142278 is just a guess. Can you try
generating an imap protocol log by following these instructions? You can mail it
to me. It's most likely the end of the log that will be interesting.

http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html#imap

thx.

Comment 4

[David :Bienvenu]

the first log Michael sent me showed no attempts to download any imap messages
for offline use - it just showed us updating the inbox headers, but no message
downloading, as if there were no folders configured for offline use. Michael, do
messages get downloaded for offline use when you just read them?

Comment 5

[Michael Zimmermann]

David,

- messages get downloaded and are available offline if I read them. 

- If I go to File > Offline > Offline Settings I see the folders I want for
offline use marked. If I check the preferences by right clicking on a folder the
offline settings are identical.

- Furthermore I checked whether automatically checking for new messages might
help > to no avail 

- The mail server seems to work correctly. I created a separete profile as a
different user (same mozilla version 1.6) but with only one account configured.
Here everything works as expected.

How about an old profile? My mozilla profile I use is from the Mozilla M7 area
or so. Might this lead to problems?

David, if you need further information or another log please don't hesitate to
ask. If you tell me how to create a more readable log for you please let me know.

Comment 6

[David :Bienvenu]

Michael, we're certainly erroring out at some point, and it probably has to do
with your account setup. Do you have an account that's not reachable or you
cancel out of when doing an offline sync, e.g., a pop3 account? The way the
offline download process works is that we update the headers for the inboxes for
all accounts; then we go update the offline folders for each account, in order.
It looks to me like the first step is failing.

Comment 7

[David :Bienvenu]

Attachment: proposed fix

this makes it so cancelling a login, or failure to reach a server, doesn't stop
the offline process. Also, must process next operation after advancing to the
next folder...

Comment 8

[David :Bienvenu]

attempted fix checked in - please try tomorrow's build and let me know if it
works. If it doesn't, we'll have to do more diagnostics.

Comment 9

[Michael Zimmermann]

David,

my computer is connected to the internet with a t1 line so I doubt that I can't
reach a server. Furthermore the imap server is running on the same machine, so
even a broken internet connection should not be a problem.

In addition to the imap accounts I have one pop3 account where the server is
located on another machine. 
What wonders me is that if I go to the "select folders for offline" panel I am
not able to select any pop3 folders from this account. 

Ok, I will report back tomorrow or the day after with the results obtained with
a new nightly bild

Comment 10

[David :Bienvenu]

Yes, I need to add a pref, and UI to get/set it, to turn off sync for a pop3
server - sync for a pop3 server just means download the new mail. We figured
that pop3 users would just always want to sync, but it turns out not to be true.

Comment 11

[Michael Zimmermann]

David,

tested it with todays nightly build (Gecko/20040310). Still the same situation
as before. I start the sync process, all folders are somehow checked and thats
it. Mozilla does no go offline nor does it seem to download any messages.

Reopening this bug. I hope this is ok with you :-)

What else can I test to help you in tracking this bug down? Do you need another
log? Or should I try to create a new profile with the same account setup?

Comment 12

[David :Bienvenu]

Michael, can you send me your prefs.js so I can see what your account setup
looks like? Also, a new imap protocol log might be helpful. And, sending a
message to the pop3 account, waiting for a bit, and then doing the
download/sync, and seeing if the pop3 mail was downloaded would be interesting.

Creating a new profile with the same account setup would be a useful experiment,
I think.

Comment 13

[Michael Zimmermann]

David,

just created a completely new profile from scratch. Even after migrating
booksmarks, password data and adding all the settings I had in my account
before, now the offline download works perfectly. 

All messages get downloaded and are available offline...

COuld it be that I had a defunct user profile?

Comment 14

[David :Bienvenu]

Not defunct, but there's something about the profile that's preventing us from
getting to the phase of downloading messages for offline use in non-inbox
folders.  It would be interesting to compare the prefs.js from the new profile
that works with the prefs.js from the old profile (I still have the latter).

Comment 15

[David :Bienvenu]

I notice from the logs that the mz016 account is the last one that we try
download, and that it's not set up to download message bodies on get new mail;
nor does it have any messages in the INBOX. I'll look through the code and see
if that could be involved. I bet something about that account is stalling the
going offline process.

Re why a new profile might work, we iterate over the accounts using a hashtable,
so the order is based on the hash of the server key. When you created the new
profile, the servers probably got different keys, so it might be that we do
other accounts before we get to the account that's making us stall. A log from
the new profile would be interesting as well.

Comment 16

[David :Bienvenu]

Attachment: add more logging to diagnose this

this adds some logging in the offline sync stop url listener, so I can tell if
we're getting notified about the url finishing.

Comment 17

[Scott MacGregor]

Comment on attachment 143974 [details] [diff] [review]
add more logging to diagnose this

sr=mscott for the logging improvements

Comment 18

[David :Bienvenu]

Comment on attachment 143974 [details] [diff] [review]
add more logging to diagnose this

I'd like to get this into a build so that I can perhaps track down this
problem...

Comment 19

[chris hofmann]

Comment on attachment 143974 [details] [diff] [review]
add more logging to diagnose this

a=chofmann for 1.7b

Comment 20

[David :Bienvenu]

Michael, I've added a little bit more logging. If you could try tomorrow's 1.7
build with your profile that fails, and e-mail me the log, I'll have a better
idea of where it's failing. Thx!

Comment 21

[David :Bienvenu]

Attachment: fix for one instance of this

I did find a reproducible case for this - it had to do with a slightly messed
up profile, such that there were a couple identical servers, and the url
listener was getting trounced, such that the offline sync wasn't getting
notified of the url finishing. This fixes it by using the url's ability to have
multiple listeners.

Comment 22

[David :Bienvenu]

Comment on attachment 145296 [details] [diff] [review]
fix for one instance of this

this is a fairly safe fix that could help some mysterious problems going
offline...

Comment 23

[chris hofmann]

Comment on attachment 145296 [details] [diff] [review]
fix for one instance of this

a=chofmann for 1.7

Comment 24

[David :Bienvenu]

Michael, I checked in that last patch - if you can try tomorrow's build and let
me know if it works better with your "bad" profile, that would be great. Thx.

Comment 25

[Michael Zimmermann]

David,

I am out of office today and won't have time to test it over the weekend. I will
report back on monday afternoon (gmt)

Comment 26

[Scott MacGregor]

actually this patch broke the ability to synch before going offline. We now get
a spurious notification saying the url is done before we have actually done the
offline synch. As a result the user just sees a message saying "There are no new
messages to synch" instead of us actually performing the synch.

Comment 27

[David :Bienvenu]

Attachment: fix for regression

the previous patch broke downloading the inbox for offline use in the case of
just one imap server - this patch fixes that by switching the order of
listeners, and has been verified by a user...

Comment 28

[David :Bienvenu]

Comment on attachment 145357 [details] [diff] [review]
fix for regression

the problem turned out to be that one of the listeners cleared out the flag
that said we were downloading a folder for offline use, right after the
previous listener had run a url that set the flag. Switching the order of
listeners will fix this.

Comment 29

[David :Bienvenu]

Comment on attachment 145357 [details] [diff] [review]
fix for regression

need to fix this regression for those poor folks with just one imap server...

Comment 30

[Michael Zimmermann]

Using a nightly build from 06/04/2004 and my defunct profile 

Result: same as before i. e. the download of messages does not complete; mozilla
does not switch to offline mode; no error messages are shown

Comment 31

[chris hofmann]

Comment on attachment 145357 [details] [diff] [review]
fix for regression

a=chofmann for 1.7

Comment 32

[Asa Dotzler [:asa]]

Comment on attachment 145357 [details] [diff] [review]
fix for regression

a=asa (on behalf of drivers) for checkin to 1.7

Comment 33

[Karen Huang]

Verified as fix on latest 1.7 branch 06-29 Linux build.
Changing keywords from fixed1.7 to verified1.7.
Shouldn't this bug resolve as fixed already?

Comment 34

[Michael Zimmermann]

As the reporter of the bug I can say that the problem still persists with newest
nightly if - and only if- I use my old defunct profile that dates back way
before mozilla 1.0.

Using a new profile I do not have any trouble.

Comment 35

[Misak Khachatryan]

Is this bug still exist ? I' can't reproduce

Comment 36

[Tony Mechelynck [:tonymec]]

Tentatively resolving WORKSFORME in the light of comment #34.

If you can reproduce this bug on SeaMonkey 2.0a1pre, please REOPEN but also give clear and unambiguous "Steps to Reproduce" with "Actual Results" and "Expected Results".