236639 - Chatzilla should use locale date/time formats

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

Currently ChatZilla relies of Date's toString() to format date/time strings.
This produces an unfriendly, fixed format. Using toLocaleString() should produce
a OS/user set locale-dependant version of it.

It has been suggested to use the nsIScriptableDateFormat, but I feel this is a)
overkill, and b) if toLocaleString() doesn't work right, it's a bug in the Date
object.

Comment 1

[James Ross]

I came up with an evil way to do this earlier; replace Date.prototype.toString
with our own little routine that called nsIScriptableDateFormat.FormatDateTime.
It worked suprisingly well, as it only seems to affect the ChatZilla window.

Comment 2

[James Ross]

Attachment: Uses nsIScriptableDateFormat to replace Date's toString

This replaces Date.prototype.toString to use nsIScriptableDateFormat and the
OS' long date format. It also changes so the statusbar and log timestamp use
the OS' short date format.

The toString replacement only affects the ChatZilla window, and makes dates
like the topic set date show up in the current locale's format.

Comment 3

[James Ross]

Comment on attachment 143247 [details] [diff] [review]
Uses nsIScriptableDateFormat to replace Date's toString

Checked in.

Comment 4

[James Ross]

I believe the patch just checked in covers this bug, marking FIXED. If this is
not correct, please reopen stating why.