Closed
Bug 236700
Opened 21 years ago
Closed 21 years ago
The "v" key brings up the find dialog
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: yuanyi21)
Details
Attachments
(1 file)
|
960 bytes,
patch
|
caillon
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
With the checkin for bug 229438 (or at least on the same day, and I see no other
reasons this would happen) typing the "v" key brings up the find dialog. This
makes typeahead-find rather difficult to use. More to the point, that's not the
behavior that patch was aiming at....
|
Reporter | |
Updated•21 years ago
|
Flags: blocking1.7b?
oh, I'm sorry. Will look into this soon.
Status: NEW → ASSIGNED
This is not caused by xul preprocessor. VK_19 binding for browser is in a
platform specific xul file -
xpfe/browser/resources/content/navigatorOverlay.xul. I didn't use a #ifdef
staff here.
The original patch (attachment 137978 [details] [diff] [review]) used the correct attrbiute. It is my
mistake to change it during moving the patch.
|
|
Reporter | |
Comment 3•21 years ago
|
||
Comment on attachment 143158 [details] [diff] [review]
I really should use |keycode| instead of |key| for the keybinding
sr=bzbarsky
Attachment #143158 -
Flags: superreview+
|
||
Updated•21 years ago
|
Attachment #143158 -
Flags: review+
checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•21 years ago
|
Flags: blocking1.7b?
|
||
Updated•6 years ago
|
Component: Keyboard: Navigation → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•