236725 - The security icon when doubleclicked, opens the Security Page Info twice.

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect, P3)

Description

[Georgi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

When you go to an https:// zone in the bottom left side of the statusbar is
displayed and icon (a padlock) and when you click in once it shows the Security
Page Info. But if you click it twice (which is more intuitive) it opens 2
instanses of the Security Page Info.

And because the Security Page Info dialog takes 1-2 seconds to Show Up, user can
click 5 to 6 times on the icon and then six instanses of the Security Page Info
dialog will open.


Reproducible: Always
Steps to Reproduce:

Comment 1

[Bill Mason]

->Toolbars

Confirming new (20040306 PC/WinXP), but could be ruled invalid or a wontfix. 
The same issue in the Mozilla suite was ruled invalid in bug 133175.

Comment 2

[Simon Paquet [:sipaq]]

Taking.

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Extensive Patch

This fixes the issue by invoking a modal page info window.
I also fixed the issue, that you could invoke more than one page info dialog
from the menubar.

Comment 4

[Simon Paquet [:sipaq]]

Comment on attachment 143968 [details] [diff] [review]
Extensive Patch

Ben, could you please review this pretty small patch. I think that the ability
to invoke countless page info dialogs by continuously clicking on the
security-icon is a severe usability issue.

Comment 5

[Simon Paquet [:sipaq]]

Attachment: Extensive Patch 2.0

per review-comments from Ben over IRC.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 143983 [details] [diff] [review]
Extensive Patch 2.0

r=[e-mail] with nit fixed:

DialogProperties -> dialogFeatures

("features" is the term we use for that parameter)

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 143983 [details] [diff] [review]
Extensive Patch 2.0

>-  window.openDialog("chrome://browser/content/pageInfo.xul",
>-                    "_blank",
>-                    "chrome,dialog=no",
>-                    doc);
>+  #ifdef XP_MACOSX
>+    var DialogProperties = "chrome,dialog=no";
>+  #else
>+    var DialogProperties = "chrome,dialog,modal,resizable";
>+  #endif
>+    window.openDialog("chrome://browser/content/pageInfo.xul",
>+                      "_blank",
>+                      DialogProperties,
>+                      doc);

Why are we making the dialog modal?  This violates the GNOME HIG for when to
use modal dialogs, and makes Page Info less useful if you can't interact with
the page as well.  I don't think this is the right fix.  pch is the GNOME HIG
guru, you might want to ping him for suggestions.

Comment 8

[Jeremy Hannon]

This dialog should NOT be made modal.  Although, I rarely have need to have the
security information open while browsing or doing other tasks, I often click the
security tab to look an encryption first, and then go to other page info tabs
that I do want to keep open.

I am not that familiar with Mozilla source (yet), but isn't there a way to set a
flag that the dialog is loading, and clear it when it has finished loading. 
Then, if the flag is set, just ignore the click.

It may not be the "ideal" way to fix it, but it would definitely work, with
little overhead.  Then again, I don't know the Mozilla source well yet, so maybe
I am a little crazy.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

How about this instead. The status bar icons should activate on double click
(I'm not aware of any single click convention).

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

fixed br and trunk.