236751 - no keyboard shortcuts for toggling message pane and folder list pane

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Vaclav Dvorak]

I'd like to have keyboard shortcuts for toggling the visibility of the message
pane (i.e., the bottom part of the window) and the folder list (i.e., the left
part). F8 and F9 seem to be available in MailNews. F9 for the folder list would
be a good analogy with the sidebar (both open on the left).

I understand that function keys are unwelcome on the Mac, so that platform might
have to use something else, or perhaps nothing at all - someone with Mac
experience should decide that.

F8 was proposed for toggling the search bar in bug 107666.

If I had to choose just one of those features, I'd like to be able to toggle the
message pane with one key.

Comment 1

[Vaclav Dvorak]

Attachment: patch to add F8 and F9 keybindings to MailNews

This is how I'd like it to be.

Comment 2

[[e-mail]]

Comment on attachment 143508 [details] [diff] [review]
patch to add F8 and F9 keybindings to MailNews

It occurs to me that the existing VK_F6 and these new keys will generate JS
errors if someone tries them in the standalone message window ;-)

Comment 3

[Vaclav Dvorak]

Comment on attachment 143508 [details] [diff] [review]
patch to add F8 and F9 keybindings to MailNews

Thanks for the speedy reviews!

Comment 4

[Vaclav Dvorak]

Is there anyone else who should approve the keyboard shortcuts? The
http://www.mozilla.org/docs/end-user/moz_shortcuts.html page lists
[e-mail] and [e-mail] as the people to notify of changes -
are the netscape.com addresses still valid?

Comment 5

[Vaclav Dvorak]

Attachment: patch for http://www.mozilla.org/docs/end-user/moz_shortcuts.html

Comment 6

[chris hofmann]

Comment on attachment 143508 [details] [diff] [review]
patch to add F8 and F9 keybindings to MailNews

aaronl is at IBM now.  I'll send mail  

a=chofmann for 1.7b

Comment 7

[Vaclav Dvorak]

Cool. Bienvenu, could you check this in for me, please? Thanks!

Comment 8

[David :Bienvenu]

fix checked in, thanks Vaclav. I need to update the doc as well.

Comment 9

[Vaclav Dvorak]

Attachment: patch for help

Here's a patch for the help. Sorry about not making this in the first place.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 143893 [details] [diff] [review]
patch for help

When this lands, please make a posting to n.p.m.seamonkey and npm.l10n
allerting localizers to the change. I don't know how many localizers localize
the help documentation, but for those that do, we should be very vocal about
any changes made after the string freeze which went into effect at beta.

Comment 11

[Vaclav Dvorak]

Neil, could you please have a look at the patch, or redirect it to whoever is
better suited for this? (I'm not ever sure I chose the right person - you're a
peer of the help module, but does it mean you're responsible for the help
contents or just the help system?) Thanks.

Comment 12

[[e-mail]]

Comment on attachment 143893 [details] [diff] [review]
patch for help

Passing this on to someone who's awake at this time of day ;-)

Comment 13

[Vaclav Dvorak]

Thanks, everyone. Now, would someone checkin the help patch, please?

Comment 14

[Vaclav Dvorak]

David? Neil? Would you check it in, please? Thanks.

Comment 15

[Vaclav Dvorak]

Boris, you've been a quick responder... could you please check in the help patch
for me? It would be a shame to miss 1.7 with this. Thanks!

Comment 16

[Boris Zbarsky [:bzbarsky]]

I can try to do it tomorrow evening, but not until then....

Comment 17

[[e-mail]]

Aren't you supposed to post a late-l10n warning to the appropriate groups (sorry
I forget which)? Plus add the late-l10n keyword to this bug, of course.

Comment 18

[Vaclav Dvorak]

(In reply to comment #17)
> Aren't you supposed to post a late-l10n warning to the appropriate groups (sorry
> I forget which)? Plus add the late-l10n keyword to this bug, of course.

Yes, but shouldn't I post that _after_ the checkin? It could turn out to be a
false alarm otherwise. Also, that's why I'm trying to rush the checkin - so
there is still time before release for the localizers. I didn't know about the
keyword though, thanks for that, I'm adding it now.

Comment 19

[[e-mail]]

OK, it's in, now get posting :-P

Comment 20

[Vaclav Dvorak]

Posted: news://news.mozilla.org:119/c4csll$[e-mail]
Thanks for the checkin.