236897 - text-decoration: blink: it's impossible to turn off, or on via DOM

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P3)

Description

[Gyuris Gellért]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; hu-HU; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; hu-HU; rv:1.6) Gecko/20040206 Firefox/0.8

it's impossible to turn off, or on via DOM

Reproducible: Always
Steps to Reproduce:
1. switch text-decoration 
2.
3.

Comment 1

[Gyuris Gellért]

Attachment: testcase

Comment 2

[Elmar Ludwig]

See also bug 179079 (might be related, but does not involve scripting).

Comment 3

[José Jeria]

(In reply to comment #2)
> See also bug 179079 (might be related, but does not involve scripting).

Last testcase does

Comment 4

[Boris Zbarsky [:bzbarsky]]

Probably an issue with the textframes not killing off the blink timer... The
problem is that text frames are added to and removed from the blink timer in
reflow, but changing text-decoration only does a repaint....

Comment 5

[Boris Zbarsky [:bzbarsky]]

Come to think of it, can text-decoration affect line-box sizing?  If so, could
it need reflow anyway?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I wouldn't have thought they could affect line-box sizing.

I don't see a problem with making text-decoration just do a reflow. It's
unlikely to be performance critical.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'd rather not make text-decoration changes reflow.  changing text-decoration on
:hover (for links) is not uncommon.

Comment 8

[Boris Zbarsky [:bzbarsky]]

The other option is to reflow only if the "blink" bit changed....  That should
happen about once in a blue moon.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Though really, maybe we should just remove blink....

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(This fixes turning off too?)

Comment 11

[Boris Zbarsky [:bzbarsky]]

> (This fixes turning off too?)

Yep.  Fixes all testcases in this bug and in bug 179079.  Taking, I guess.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Checked in for 1.8a.