236946 - Small cleanup in nsXULElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

I saw a few places in nsXULElement which QI itself for no good reason, and a few
places which do |if (foo) bar = do_QueryInterface(foo)|, as well as some static
casts that can go which I have cleaned up.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 143429 [details] [diff] [review]
Patch

r+sr=jst

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in 03/09/2004 17:34 PST.

Comment 4

[[e-mail]]

Comment on attachment 143429 [details] [diff] [review]
Patch

>-    *aResult = NS_REINTERPRET_CAST(nsIStyledContent*, element);
>+    *aResult = NS_REINTERPRET_CAST(nsIStyledContent*, element.get());
>     NS_ADDREF(*aResult);
Not cleaned up enough :-P
NS_ADDREF(*aResult = element);

Comment 5

[HJ]

He guys, I like to reopening this bug, but I'll wait for you to reply, because
it is causing me a lot of trouble. I keep crashing with
element.builder.rebuild() It still works in 20040308 but fails in all builds
with this patch. Here's a small code example:

          <menu label="&qpHTTPUserAgentSettings.label;">
            <menupopup id="UAgentMenu" datasources="rdf:null"
ref="urn:useragent-data" 
                       onpopupshowing="initUserAgentMenu(this);">
              <template>
                <rule>
                  <menuitem uri="rdf:*" label="rdf:*" type="radio"/>
                </rule>
              </template>
            </menupopup>
          </menu>

function initUserAgentMenu(aParent)
{
  aParent.builder.rebuild(); <= crash !!!

Comment 6

[HJ]

Darn, I forot to CC myself. Sorry for the SPAM.

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

File a new bug.

Comment 8

[HJ]

Ok, done. http://bugzilla.mozilla.org/show_bug.cgi?id=238413