236964 - add dbprefix option for selfserv

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P3)

Description

[Julien Pierre]

This is useful to use selfserv with alternate cert databases (such as the ones
from web server, directory server). Patch forthcoming.

Comment 1

[Julien Pierre]

Attachment: add -P option for dbprefix

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 143456 [details] [diff] [review]
add -P option for dbprefix

Is something similar needed for the other tools, e.g. certutil?

Comment 3

[Julien Pierre]

Comment on attachment 143456 [details] [diff] [review]
add -P option for dbprefix

Thanks for the review, Nelson.

certutil has had this -P option for a file . It would probably be good to add
this to all the tools, but until now it's been added as-needed.

Comment 4

[Julien Pierre]

I meant - "for a while".

Checking in selfserv.c;
/cvsroot/mozilla/security/nss/cmd/selfserv/selfserv.c,v  <--  selfserv.c
new revision: 1.56; previous revision: 1.55

Comment 5

[Wan-Teh Chang]

Comment on attachment 143456 [details] [diff] [review]
add -P option for dbprefix

certPrefix needs to be freed if it doesn't point to "".

Comment 6

[Julien Pierre]

Wan-Teh,

Indeed. It seems like it's not been the usage in selfserv and most of nss/cmd to
worry about such pesky details as freeing up the variables that hold
command-line argument values, though. Doing it right would be a whole lot of
work (checking for multiple arguments of the same type and free them, etc) for
not much additional benefit.