236988 - Should show application icons in download manager

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

When we have an application's file, we should be able to show its icon. See URL.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: partial work

If the file being referenced is an executable, make moz-icon extract the icon
at index 0 from that file's resources, rather than using the system exe icon (a
plain looking empty window)

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: better documented patch for icon decoder with improved logic

Comment 3

[Ali Ebrahim]

*** Bug 236235 has been marked as a duplicate of this bug. ***

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: OK, done.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 143538 [details] [diff] [review]
OK, done.

After looking at mkaply's patch in the other bug and adapting the download
manager slightly, turns out nothing needs to be done in the windows version of
nsIconChannel... However there is still a bug in nsIconURI.

When SetSpec is called, the scheme is chopped off, leaving: "//file:///c:\..."
... the code is structured so that it assumes that if the remainder starts with
"//" it's not a URL.... but the case I just described is clearly a File URL. So
we need the code to trim the "//" and THEN check for the "file://" prefix as
the determination of whether or not this is a file URL.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 143538 [details] [diff] [review]
OK, done.

a=asa

Comment 7

[José Jeria]

I still dont see this, tested on 2 different computers with latest builds,
windows 2000 and windows XP.

Comment 8

[Sergei Dolgov]

to Ben's comment.
https://bugzilla.mozilla.org/show_bug.cgi?id=280944
looks like DUP,
but there are still problems with URI used as native path, at least for BeOS

Comment 9

[Doug Shelton]

thanks, fyysik!  I appreciate you looking at this.  The download manager icon fix won't really be complete until this is also taken care of.