237001 - clean up nsLegacyCheck and nsObjectIgnore

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Andrew Schultz]

nsLegacyCheck currently contains methods SetFileName, SetMessage and InitNext,
which it needs because it doesn't pass the parameters like nsRunApp does.  This
is pretty easy to fix in the parser, which would allow the mehods to be removed.
 nsLegacyCheck becomes an nsRunApp clone.

the same is needed for the nsObjectIgnore class from bug 234741 once it exists.

Comment 1

[Andrew Schultz]

Attachment: patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 143495 [details] [diff] [review]
patch

Since these classes are essentially the same, can they be unified?

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 143495 [details] [diff] [review]
patch

>-nsLegacyCheck::InitNext()
>-{

InitNext() is still in the .h file, does this link?

>+    char *currVal = NULL, *currVal2 = NULL;

"currVal" gets used for two different things, two separate more descriptive
names would be better if you feel like cleaning up the old code. There's no
excuse for currVal2, though, it's only used for the legacy check message.

sr=dveditz with those nits.

Comment 4

[Andrew Schultz]

Attachment: patch for checkin

patch addressing dveditz's nits and updated to trunk

Comment 5

[Andrew Schultz]

Attachment: patch6

identical changes to nsObjectIgnore

Comment 6

[Andrew Schultz]

Comment on attachment 146398 [details] [diff] [review]
patch for checkin

bz checked this in

Comment 7

[Andrew Schultz]

Comment on attachment 146426 [details] [diff] [review]
patch6

more of the same...

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 146426 [details] [diff] [review]
patch6

sr=dveditz

Comment 9

[Andrew Schultz]

checked in by timeless