Closed
Bug 237042
Opened 21 years ago
Closed 21 years ago
optimize nsRuleNode::GetStyleData
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.7beta
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: perf, Whiteboard: [patch])
Attachments
(1 file)
|
3.89 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
chofmann
:
approval1.7b+
|
Details | Diff | Splinter Review |
There are a few things that could speed up nsRuleNode::GetStyleData and
GetParentData:
* NS_LIKELY / NS_UNLIKELY (for modern gcc with -O2)
* using dependent bits checks more and cached style data checks less (since the
two should be equivalent in many ways)
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.7beta
|
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #143527 -
Flags: superreview?(bzbarsky)
Attachment #143527 -
Flags: review?(bzbarsky)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 143527 [details] [diff] [review]
patch
r+sr=bzbarsky
Attachment #143527 -
Flags: superreview?(bzbarsky)
Attachment #143527 -
Flags: superreview+
Attachment #143527 -
Flags: review?(bzbarsky)
Attachment #143527 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Comment on attachment 143527 [details] [diff] [review]
patch
This should be pretty low risk since if it breaks anything, it should break
pretty much everything.
Attachment #143527 -
Flags: approval1.7b?
|
||
Comment 4•21 years ago
|
||
Comment on attachment 143527 [details] [diff] [review]
patch
a=chofmann for 1.7a
Attachment #143527 -
Flags: approval1.7b? → approval1.7b+
|
|
||
Comment 5•21 years ago
|
||
er, 1.7b
|
|
Assignee | |
Comment 6•21 years ago
|
||
Fix checked in to trunk, 2004-03-14 09:11 -0800.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•