237076 - Object hierarchy is broken @ nsOuterDocAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Kyle Yuan]

Using at-poke to poke the accessible object hierarchy of mozilla, it will stop
at the 3rd level of "panel" object.

Comment 1

[Kyle Yuan]

That is because when called nsOuterDocAccessible::GetChildCount, it  asks
nsAccessible::CacheChildren to get its children number. But for
nsOuterDocAccessible, its child can not be obtained by nsAccessibleTreeWalker,
its child is hard-coded to a nsDocAccessible object. So we have to always return
1 for the ChildCount of nsOuterDocAccessible.

Comment 2

[Kyle Yuan]

Attachment: patch

the description of this patch is in my previous comment.

Comment 3

[Kyle Yuan]

Comment on attachment 143560 [details] [diff] [review]
patch

hold on, the problem is  more complicate than I can imagine.
nsOuterDocAccessible::GetChildCount gets called even before the constructor.

Comment 4

[Kyle Yuan]

Comment on attachment 143560 [details] [diff] [review]
patch

My previous comment was wrong. The constructor did get called before
GetChildCount, but unfortunately, mAccChildCount was cleared by
nsAccessible::InvalidateChildren again. So my patch is still applicable.

Comment 5

[Henry Jia]

Comment on attachment 143560 [details] [diff] [review]
patch

sr=Henry

Comment 6

[Kyle Yuan]

Comment on attachment 143560 [details] [diff] [review]
patch

this fix is small but very important to linux accessibility feature.

Comment 7

[Aaron Leventhal]

Is this going into 1.8?

Comment 8

[Kyle Yuan]

checked in trunk. Still waiting for 1.7branch...

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 143560 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.7

Comment 10

[Kyle Yuan]

fixed in 1.7 branch.

Comment 11

[mmc]

Could you add the fixed1.7 keyword?