237079 - the "open with" --> "other" option should launch the windows "open with" dialog

Status: RESOLVED DUPLICATE of bug 348808

(Toolkit :: Downloads API, enhancement)

Description

[:glob ✱]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040307 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040307 Firefox/0.8.0+

when downloading a file that isn't managed directly by firefox, you're prompted
for an action, either selecting an application or saving to disk.

if you choose "open with", then select "other", you're presented with a standard
file dialog with the filter set to applications.

on windows firefox should use shell32's native "open with" dialog.

it's exported as "OpenAs_RunDLL" from shell32.dll.

i looked for docs on msdn, couldn't find, so here's how to call it (quick and
very dirty code)

procedure openWith(const fileName: string);
var
  openAs_RunDLLA: procedure(HWND: THandle; HInstance: THandle; cmdLine: PChar;
cmdShow: Integer); stdcall;
begin
  @openAs_RunDLLA := GetProcAddress(LoadLibrary('shell32.dll'), 'OpenAs_RunDLLA');
  openAs_RunDLLA(0, 0, pChar(fileName), SW_SHOW);
end;


Reproducible: Always
Steps to Reproduce:
1. click to download file not managed by firefox
2. choose other from the open with popup menu


Actual Results:  
normal open file dialog

Expected Results:  
windows open with dialog

Comment 1

[Ali Ebrahim]

This is a good idea for an enhancement.

--> enh

Comment 2

[Tzafrir Cohen]

Not on all platforms:

The gtk2 dialog is currently quite bad for this task: I wanted to choose "gv"
instead of the default ggv. I have no way of putting a command that will be
search in the patch (notr to mention a more complicated shell command). Thus I
have to find out in which directory gv resides (/usr/bin ? /usr/X11R6/bin?
/usr/local/bin? what happens if I install a new copy in /usr/local/bin to
override the distro copy?)

And navigating to the crowded directory of /usr/bin to locate gv there is not
the fastest thing to do. Quite time consuming.

Comment 3

[:glob ✱]

there's another location that should use native open-with:

  options
  downloads
  file types
  change action
  open with


note that gnome's gmc also has an open with dialog.

Comment 4

[John Mellor (Jomel)]

Tzafrir: this is a Windows bug, bug 259594 deals with the equivalent problem on
Linux

The shell's open with dialog is ideal for this, as it lists applications which
have registered themselves as being capable of opening files (with friendly
names), as well as allowing the user to browse to a program of their choice.

bug 281403 is a duplicate of this one, someone please mark it as such

Comment 5

[John Mellor (Jomel)]

Attachment: The native Windows "Open With" dialog

Comment 6

[Keith Lea]

*** Bug 281403 has been marked as a duplicate of this bug. ***

Comment 7

[Shawn Wilsher :sdwilsh]

Jim, does Bug 348808 accomplish this?

Comment 8

[:glob ✱]

looks like the work is being done on bug 348808, marking as a duplicate.