237091 - Remove unused WindowOffset and RootWidget functionality from nsViewManager

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P1)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is very simple cleanup.

nsIViewManager exports a SetWindowOffset/GetWindowOffset pair. SetWindowOffset
is called by nsDocumentViewer. GetWindowOffset is never called. The mX/mY values
are never used by anything except these two functions. I don't know what this
was supposed to be for. It's dead code. Let's just get rid of it.

nsIViewManager::SetRootView allows you to set a widget along with the root view.
This extra parameter is always null in all callers. Removing it eliminates any
need for special handling of mRootWindow; the root widget is now always the
widget associated with the root view, if any. I don't know what the general
functionality was supposed to be but it confuses me and probably doesn't work,
since it's never tested. We don't need to store mRootWindow at all.

I think the above functions might have been supposed to be used by embedders. I
don't think embedders are using them and embedders can probably just wrap a
Gecko widget in an outer wrapper widget to get whatever effects they're looking for.

I also rearranged the fields of nsViewManager to pack booleans.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: complete fix

Forgot to include diff of nsDocumentViewer.cpp

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 143683 [details] [diff] [review]
complete fix

This is 1.8a stuff, David. So no hurry.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fix checked in.

Comment 5

[tenthumbs]

I'm getting this assertion:

###!!! ASSERTION: Must have a root view: 'view', file nsViewManager.cpp, line 578
Break: at file nsViewManager.cpp, line 578

on every page I load with my Linux gtk1 trunk build from this morning. Is it
really necessary?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Probably not. I will track it down.