237169 - decomify and rename nsIFrame::IsPercentageBase

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I want to deCOMify the signature of nsIFrame::IsPercentageBase and give it a
less cryptic name.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

In my opinion we should move away from this api altogether in the long run.  The
only users seem to be the reflow state, the style struct calculation code, and
computed style.  The last two actually want GetContainingBlock(), while the
reflow state will need to be adjusted anyway to handle relatively positioned
inlines with absolutely positioned kids (which case is handled incorrectly by
the style struct and computed style code, by the way).

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

See also bug 236966.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 143651 [details] [diff] [review]
patch

r+sr=bzbarsky

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 143651 [details] [diff] [review]
patch

Simple cleanup that I'd like to land to get started with other things.

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 143651 [details] [diff] [review]
patch

a=brendan, sure.

/be

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-03-11 20:40 -0800.

Comment 9

[Alex Fritze]

This checkin breaks debug builds in nsComputedDOMStyle.cpp. A semicolon is missing:

Index: nsComputedDOMStyle.cpp
===================================================================
RCS file: /cvsroot/mozilla/content/html/style/src/nsComputedDOMStyle.cpp,v
retrieving revision 1.105
diff -u -r1.105 nsComputedDOMStyle.cpp
--- nsComputedDOMStyle.cpp	12 Mar 2004 04:40:16 -0000	1.105
+++ nsComputedDOMStyle.cpp	12 Mar 2004 08:53:35 -0000
@@ -2889,7 +2889,7 @@
   nsIFrame* container = aFrame;
   do {
     container = container->GetParent();
-  } while (container && !container->IsContainingBlock())
+  } while (container && !container->IsContainingBlock());
 
   NS_POSTCONDITION(container, "Frame has no containing block");
   return container;

Comment 10

[Alex Fritze]

bustage fix checked in.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oops.  Thanks for fixing that.

Comment 12

[Bernd]

*** Bug 231341 has been marked as a duplicate of this bug. ***