Closed Bug 237186 Opened 21 years ago Closed 21 years ago

document.createAttribute, document.createElement, etc need to throw INVALID_CHARACTER_ERR for empty names

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file)

The DOM WG seems to have decided that these methods should throw INVALID_CHARACTER_ERR for empty names. We're not applying this fix to DOMImplementation.createDocument since document.implementation.createDocument("", "", null); appears to be common usage.
Attached patch FixSplinter Review
Attachment #143665 - Flags: superreview?(jst)
Attachment #143665 - Flags: review?(jst)
Comment on attachment 143665 [details] [diff] [review] Fix r+sr=jst
Attachment #143665 - Flags: superreview?(jst)
Attachment #143665 - Flags: superreview+
Attachment #143665 - Flags: review?(jst)
Attachment #143665 - Flags: review+
Comment on attachment 143665 [details] [diff] [review] Fix Just changes the error code of the exception that we throw for an empty name from a bunch of DOM methods. Very low risk.
Attachment #143665 - Flags: approval1.7b?
Comment on attachment 143665 [details] [diff] [review] Fix a=chofmann for 1.7b
Attachment #143665 - Flags: approval1.7b? → approval1.7b+
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Component: DOM: Core → DOM: Core & HTML
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: