Closed
Bug 237186
Opened 21 years ago
Closed 21 years ago
document.createAttribute, document.createElement, etc need to throw INVALID_CHARACTER_ERR for empty names
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: peterv, Assigned: peterv)
Details
Attachments
(1 file)
|
712 bytes,
patch
|
jst
:
review+
jst
:
superreview+
chofmann
:
approval1.7b+
|
Details | Diff | Splinter Review |
The DOM WG seems to have decided that these methods should throw
INVALID_CHARACTER_ERR for empty names. We're not applying this fix to
DOMImplementation.createDocument since
document.implementation.createDocument("", "", null); appears to be common usage.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #143665 -
Flags: superreview?(jst)
Attachment #143665 -
Flags: review?(jst)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 143665 [details] [diff] [review]
Fix
r+sr=jst
Attachment #143665 -
Flags: superreview?(jst)
Attachment #143665 -
Flags: superreview+
Attachment #143665 -
Flags: review?(jst)
Attachment #143665 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Comment on attachment 143665 [details] [diff] [review]
Fix
Just changes the error code of the exception that we throw for an empty name
from a bunch of DOM methods. Very low risk.
Attachment #143665 -
Flags: approval1.7b?
|
||
Comment 4•21 years ago
|
||
Comment on attachment 143665 [details] [diff] [review]
Fix
a=chofmann for 1.7b
Attachment #143665 -
Flags: approval1.7b? → approval1.7b+
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•