237213 - [FIXr]Replace nodetype check with IsContentOfType in nsContentList

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

The two should be equivalent, and the latter is faster and less code.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 143681 [details] [diff] [review]
Patch

+    if (!aContent->IsContentOfType(nsIContent::eELEMENT)) {
       return PR_FALSE;
+    }

+    nsINodeInfo *ni = aContent->GetNodeInfo();
+    if (!ni) {
+      NS_ERROR("Element without nodeinfo!");
       return PR_FALSE;

This is not needed any more then, all elements have nodeinfo, if they don't,
they're broke and should be fixed.

r+sr=jst with that unnecessary check removed.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch updated to comments

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fix checked in for 1.8a.