237231 - make xpistub interface description and implementation agree

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Andrew Schultz]

xpistub.h says that XPI_Init
1. takes parameters aProgramDir, startCB, progressCB and finalCB
2. aProgramDir: "...If NULL default will be used -- the location of the calling
executable."

in xpistub.c, XPI_Init
1. takes parameters aProgramDir, aLogName and progressCB
2. if aProgramDir is NULL, XPI_Init crashes
http://lxr.mozilla.org/mozilla/source/xpinstall/stub/xpistub.cpp#197

for #1, the interface description should be updated.
I'd like to actually implement #2 for use in bug 77365

Comment 1

[Andrew Schultz]

Attachment: patch

cleanup xpistub.h and implement handling NULL aProgramDir parameter.

Comment 2

[Benjamin Smedberg]

Comment on attachment 143871 [details] [diff] [review]
patch

r=me
please remove the XP_MAC cruft in this file, while you're touching it (we no
longer support MacOS9).

Comment 3

[Andrew Schultz]

Attachment: patch + remove XP_MAC

Comment 4

[Andrew Schultz]

Comment on attachment 144745 [details] [diff] [review]
patch + remove XP_MAC

this already has r=bsmedberg

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 144745 [details] [diff] [review]
patch + remove XP_MAC

Thanks!
sr=dveditz

Comment 6

[Andrew Schultz]

Attachment: patch merged to trunk (for checkin)

Comment 7

[Andrew Schultz]

checked in by timeless