237249 - Accessible name of web location combo box is too long

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Dana Ormenisan]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040311
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040311

The accessible name of the combo box where we insert the URL for navigation is
too long. 
It should be 'web location' or an other appropriate value, but much shorter than
its actual name. 

Reproducible: Always
Steps to Reproduce:
1.Launch gnopernicus and turn on the speech
2.Launch mozilla
3.Focus the web location combobox

Comment 1

[Aaron Leventhal]

True -- that really is annoying, and shouldn't be hard to fix.

One solution would be to use the tooltiptext when it's there. In this case
that's "Enter search term, keyword or web address", but perhaps that's also too
long.

If we want something like "web location" or "address" then we have to manually
set the accessible name for this particular control. I'm not sure we have a way
for such fine tuning at the moment. Needs investigation.

Kyle, do you have any ideas?

Comment 2

[Kyle Yuan]

I think it's time to do some special work for the URL bar, not only the name,
but also the role, action etc. It's a very important widget that we must make it
work pretty good. 

CCing Louie.

Comment 3

[Aaron Leventhal]

Attachment: 1) Re-port releveant parts of bug 244624 to toolkit's autocomplete that were wiped out during Aviary merge, 2) Add accessible title to textfields so they have a usable accessible name

Comment 4

[[e-mail]]

So how does this title attribute work?

Comment 5

[Aaron Leventhal]

If we see a tooltiptext or title attribute is present we'll use it for the
accessible name for an object. If the title attribute is not official XUL then
we can change these to be tooltiptext.

However, I do see the title attribute is present in browser.xul right above
where I'm adding it:

http://lxr.mozilla.org/seamonkey/source/browser/base/content/browser.xul#204

Comment 6

[Aaron Leventhal]

Attachment: Use hidden label instead of title attribute which is only legal on toolbaritem

Comment 7

[[e-mail]]

Comment on attachment 173947 [details] [diff] [review]
Use hidden label instead of title attribute which is only legal on toolbaritem

sr=me for xpfe

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 173947 [details] [diff] [review]
Use hidden label instead of title attribute which is only legal on toolbaritem

r=me, but I'd like to see you do something with the really long lines. 
Comments especially can wrap, if you're going past the de facto margin.  Some
of these are 25-30 chars past the next longest line.

Comment 9

[Aaron Leventhal]

Attachment: Use <toolbaritem>'s title for a name if it parents the current widget. Fixes both location bar and seach field, and avoids use of hidden label in browser.xul.

Philip, I'm seeking r= for the non-chrome parts
The chrome parts are already reviewed.

Comment 10

[Aaron Leventhal]

From IRC, Neil wrote:
aaronlev: you can write r+sr because the changes are so small

So all we need now is r= and sr= for C++ changes (and a= for whole patch if we
can get it).

Comment 11

[Aaron Leventhal]

Attachment: Uncomment 2 lines that were accidentally commented out

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 173977 [details] [diff] [review]
Uncomment 2 lines that were accidentally commented out

a=dveditz for 1.8b

Comment 13

[Aaron Leventhal]

Checking in accessible/src/base/nsRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v  <-- 
nsRootAccessible.cpp
new revision: 1.108; previous revision: 1.107
done
Checking in layout/xul/base/public/nsIMenuFrame.h;
/cvsroot/mozilla/layout/xul/base/public/nsIMenuFrame.h,v  <--  nsIMenuFrame.h
new revision: 1.14; previous revision: 1.13
done
Checking in layout/xul/base/src/nsBoxFrame.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsBoxFrame.cpp,v  <--  nsBoxFrame.cpp
new revision: 1.267; previous revision: 1.266
done
Checking in layout/xul/base/src/nsBoxFrame.h;
/cvsroot/mozilla/layout/xul/base/src/nsBoxFrame.h,v  <--  nsBoxFrame.h
new revision: 1.91; previous revision: 1.90
done
Checking in layout/xul/base/src/nsMenuBarFrame.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsMenuBarFrame.cpp,v  <--  nsMenuBarFrame.cpp
new revision: 1.130; previous revision: 1.129
done
Checking in layout/xul/base/src/nsMenuFrame.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsMenuFrame.cpp,v  <--  nsMenuFrame.cpp
new revision: 1.286; previous revision: 1.285
done

Comment 14

[Aaron Leventhal]

Corrected checkin info:

Checking in toolkit/content/widgets/autocomplete.xml;
/cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v  <--  autocomplete.xml
new revision: 1.37; previous revision: 1.36
done
Checking in xpfe/browser/resources/content/navigator.xul;
/cvsroot/mozilla/xpfe/browser/resources/content/navigator.xul,v  <--  navigator.xul
new revision: 1.426; previous revision: 1.425
done
Checking in xpfe/browser/resources/locale/en-US/navigator.dtd;
/cvsroot/mozilla/xpfe/browser/resources/locale/en-US/navigator.dtd,v  <-- 
navigator.dtd
new revision: 1.179; previous revision: 1.178
done
Checking in accessible/src/base/nsAccessibilityAtomList.h;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityAtomList.h,v  <-- 
nsAccessibilityAtomList.h
new revision: 1.13; previous revision: 1.12
done
Checking in accessible/src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.129; previous revision: 1.128
done