Closed
Bug 237262
Opened 21 years ago
Closed 21 years ago
nsAttrAndChildArray::ReplaceChildAt() should addref before releasing
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jwkbugzilla, Assigned: jwkbugzilla)
Details
Attachments
(1 file)
|
868 bytes,
patch
|
sicking
:
review+
bzbarsky
:
superreview+
dbaron
:
approval1.7b+
|
Details | Diff | Splinter Review |
nsAttrAndChildArray::ReplaceChildAt() makes NS_RELEASE for the old value before
doing NS_ADDREF for the new one - it should be the other way round just in case
both are the same object (that's how nsCOMArray does it for example).
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #143714 -
Flags: review?(bugmail)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Comment on attachment 143714 [details] [diff] [review]
Proposed patch
looks good to me
Attachment #143714 -
Flags: review?(bugmail) → review+
|
||
Comment 3•21 years ago
|
||
Comment on attachment 143714 [details] [diff] [review]
Proposed patch
sr=bzbarsky. That's what the old ReplaceChildAt code did...
Attachment #143714 -
Flags: superreview+
|
|
||
Comment 4•21 years ago
|
||
Comment on attachment 143714 [details] [diff] [review]
Proposed patch
I think this is worth getting into beta....
Attachment #143714 -
Flags: approval1.7b?
Attachment #143714 -
Flags: approval1.7b? → approval1.7b+
|
||
Comment 5•21 years ago
|
||
checked in 03/12/2004 17:17
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•