Closed
Bug 237275
Opened 21 years ago
Closed 21 years ago
Comb wrapping for README and license; shouldn't have newlines
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: akkzilla, Assigned: ajschult784)
References
Details
Attachments
(1 file)
19.97 KB,
patch
|
dveditz
:
review+
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
The new installer stages which show the README and MPL show comb wrapping (every
other line is only a few characters long) using the default Debian fonts (this
will also be true for anyone who uses large fonts for accessibility reasons).
The textarea isn't wide enough to show the lines at their actual length.
This is cosmetic only, but gives a bad impression of mozilla since it's the
first thing the user sees.
The easy fix: remove the newlines within paragraphs in the installer's copy of
these documents, and let the textarea word-wrap the lines according to the
actual font in use.
Assignee | ||
Comment 1•21 years ago
|
||
this
1) makes the Welcom dialog (README) wrap on words.
2) removes newlines from README and removes most of the indenting, which looks
bad on only the first line.
the README content is not changed even though it's wrong (bug 58859)
Assignee: general → ajschult
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•21 years ago
|
||
*** Bug 127433 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 3•21 years ago
|
||
Comment on attachment 143773 [details] [diff] [review]
patch
dveditz: the gtk portion of this patch got r= and your sr= in bug 127433.
Attachment #143773 -
Flags: superreview?(dveditz+bmo)
Attachment #143773 -
Flags: review?(dveditz+bmo)
Comment 4•21 years ago
|
||
Comment on attachment 143773 [details] [diff] [review]
patch
r/sr=dveditz
Attachment #143773 -
Flags: superreview?(dveditz+bmo)
Attachment #143773 -
Flags: superreview+
Attachment #143773 -
Flags: review?(dveditz+bmo)
Attachment #143773 -
Flags: review+
Assignee | ||
Comment 5•21 years ago
|
||
Comment on attachment 143773 [details] [diff] [review]
patch
this patch aesthetically improves the README by properly wrapping words. very
low risk
Attachment #143773 -
Flags: approval1.7b?
Assignee | ||
Comment 6•21 years ago
|
||
see also bug 237342.
I'm not sure removing the newlines from the license is the best thing to do
since that would also removing the indenting, which is helpful, at least
compared to the README, where it doesn't really do much.
Comment 7•21 years ago
|
||
Comment on attachment 143773 [details] [diff] [review]
patch
a=chofmann for 1.7b
Attachment #143773 -
Flags: approval1.7b? → approval1.7b+
Comment 8•21 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•