237282 - Add build rule for preprocessed js components

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Alex Fritze]

It would be nice to have a rule in rules.mk that does the same as
EXTRA_COMPONENTS but filters files through preprocessor.pl before copying to the
components dir.
patch coming up.

Comment 1

[Alex Fritze]

Attachment: patch to rules.mk

This patch adds ::lib & ::install rules that filter all files given in
JS_COMPONENTS through the preprocessor & copy them to the components dir.

Comment 2

[cls]

Do we really need another define for this since EXTRA_COMPONENTS only contains
.js files?

Comment 3

[Alex Fritze]

OK, I can make another patch for that. Most makefiles that use EXTRA_COMPONENTS
need to be edited for that, since objdir builds will then require that file
names are prepended with "$(srcdir)/".
How about renaming EXTRA_COMPONENTS to JS_COMPONENTS, though? If we ever add
support for other similar components (e.g. phython components) we might not want
to put them through the preprocessor...

Comment 4

[cls]

(In reply to comment #3)
> OK, I can make another patch for that. Most makefiles that use EXTRA_COMPONENTS
> need to be edited for that, since objdir builds will then require that file
> names are prepended with "$(srcdir)/".

Actually, they don't if you use the automatic make variable $^ (I think) in the
rule instead of copying JS_COMPONENTS again.

> How about renaming EXTRA_COMPONENTS to JS_COMPONENTS, though? If we ever add
> support for other similar components (e.g. phython components) we might not want
> to put them through the preprocessor...

I'm fine with the name change.  After thinking about it some more though, I
think we may want to have an extra variable or something to use the
preprocessor.  I'm guessing that in 98% of the cases, that's going to be an
unnecessary preprocessor call.

Comment 5

[Alex Fritze]

(In reply to comment #4)
> I'm fine with the name change.  After thinking about it some more though, I
> think we may want to have an extra variable or something to use the
> preprocessor.  I'm guessing that in 98% of the cases, that's going to be an
> unnecessary preprocessor call.

OK, how about renaming JS_COMPONENTS to PREPROCESSED_EXTRA_COMPONENTS and
keeping EXTRA_COMPONENTS as well? 

Comment 6

[cls]

*** Bug 277309 has been marked as a duplicate of this bug. ***

Comment 7

[Benjamin Smedberg]

I prefer my patch from bug 277309, can I get that one reviewed?

Comment 8

[Benjamin Smedberg]

Attachment: EXTRA_PP_COMPONENTS, rev 2

Comment 9

[Benjamin Smedberg]

fixed on trunk