237302 - Upgrade libical to the most recent version in their CVS

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Mostafa Hosseini]

Comment 1

[Philip K. Warren]

Attachment: Remove icalcstp*

This removes the following files from our libical which have been removed from
libical CVS and are unused:

icalcstp.c
icalcstp.h
icalcstpclient.c
icalcstpclient.h
icalcstpserver.c
icalcstpserver.h

Comment 2

[Philip K. Warren]

First patch checked in.

Removing icalcstp.c;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstp.c,v  <--  icalcstp.c
new revision: delete; previous revision: 1.5
done
Removing icalcstp.h;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstp.h,v  <--  icalcstp.h
new revision: delete; previous revision: 1.3
done
Removing icalcstpclient.c;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstpclient.c,v  <-- 
icalcstpclient.c
new revision: delete; previous revision: 1.7
done
Removing icalcstpclient.h;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstpclient.h,v  <-- 
icalcstpclient.h
new revision: delete; previous revision: 1.2
done
Removing icalcstpserver.c;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstpserver.c,v  <-- 
icalcstpserver.c
new revision: delete; previous revision: 1.5
done
Removing icalcstpserver.h;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/icalcstpserver.h,v  <-- 
icalcstpserver.h
new revision: delete; previous revision: 1.2
done
Checking in objs.mk;
/cvsroot/mozilla/other-licenses/libical/src/libicalss/objs.mk,v  <--  objs.mk
new revision: 1.3; previous revision: 1.2
done

Comment 3

[Mostafa Hosseini]

Another minor move towards latest libical:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fother-licenses%2Flibical&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=07%2F27%2F2004+12%3A20&maxdate=07%2F27%2F2004+12%3A40&cvsroot=%2Fcvsroot

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

To do this we need to keep local patches, that are not in libical cvs. I tried
to collect the bugs where the patches are from.
bug 259956, bug 239435, bug 241961, bug 165963, bug 191447

Comment 5

[Mostafa Hosseini]

I'll be upgrading libical soon. I'll test the build on windows,linux and Mac.
Please let me know if the upgrade breaks your build.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: use calendar/libical instead of other-licenses/libical. allmakefiles.sh and Makefile.in part

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Patch for bug 239435 has been checked in to the new import.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/calendar/libical/src/libical&command=DIFF_FRAMESET&file=icalparser.c&rev1=1.1&rev2=1.2&root=/cvsroot

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

At the moment i'm waiting with the bugs that are file-io related (icalfileset)
because my idea is to use mozilla file IO. these are bug 259956 and bug 241961.
We do need to make sure the line endings are correct that way though.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Also need to test if bug 185145 is still needed. That looks like a workaround
for cygwin perl, maybe that is fixed by now.

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

New import is now enabled for base/src. libxpical is switched of.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fcalendar&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-01-07+11%3A16&cvsroot=%2Fcvsroot

Comment 11

[Mostafa Hosseini]

libical has fixed some buffer overflows:
http://sourceforge.net/mailarchive/forum.php?thread_id=6413779&forum_id=10197

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

upgraded libical to the current cvs

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch to disable building other-licenses/libical (checked in)

this patch was checked in.

Comment 14

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Internal Components. Be afraid for your sanity!