237437 - In <abDragDrop.js>, "2" "Warning: anonymous function does not always return a value"

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219] (W98SE)

{{
Warning: anonymous function does not always return a value
Source File: chrome://messenger/content/addressbook/abDragDrop.js
Line: 132, Column: 16
Source Code:
          return; // should not be here

Warning: anonymous function does not always return a value
Source File: chrome://messenger/content/addressbook/abDragDrop.js
Line: 175, Column: 4
Source Code:
    },
}}

Updating:
*(A.To) sspitzer#mozilla.org -> me

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <abDragDrop.js>

Bug fix,
plus some cleanup.

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 143881 [details] [diff] [review]
(Av1) <abDragDrop.js>


'r=?':
Could you review and test it ?

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av1b) <abDragDrop.js>

Av1, without most of the cleanup.

Comment 4

[[e-mail]]

Comment on attachment 144132 [details] [diff] [review]
(Av1b) <abDragDrop.js>

>-      if (!targetDirectory.isMailList && 
>-          (!(targetDirectory.operations & targetDirectory.opWrite)))
>-        return false;      
>-      
>-      return true;
>+    return (targetDirectory.isMailList ||
>+            (targetDirectory.operations & targetDirectory.opWrite));
r=me if you reindent this.

>       var dragSession = dragService.getCurrentSession();
>+
>       if (!dragSession)
Nit: no point separating the initialization from the test.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1c) <abDragDrop.js> [Checked in: Comment 9]

Av1b, with comment 4 suggestion(s).

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 144973 [details] [diff] [review]
(Av1c) <abDragDrop.js>
[Checked in: Comment 9]


Keeping |(Av1b) <abDragDrop.js> 	 patch		2004-03-17 07:51 PST   
neil.parkwaycc.co.uk: review+|.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 144973 [details] [diff] [review]
(Av1c) <abDragDrop.js>
[Checked in: Comment 9]


'approval1.7=?':
Trivial code fix, no risk;
(Trying v1.7 instead of waiting for v1.8a, as v1.7 will become new
long-lived...)

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 144973 [details] [diff] [review]
(Av1c) <abDragDrop.js>
[Checked in: Comment 9]

a=mkaply

Comment 9

[[e-mail]]

Fix checked in.